Skip to content

Prevents tests from leaking System V IPC objects #22912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickSdot wants to merge 2 commits into
base: master
Choose a base branch
from
+37 −1
Open

Prevents tests from leaking System V IPC objects #22912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d0c76b
Clean up IPC objects in arginfo mismatch test
NickSdot Jul 28, 2026
ab7526b
Fix GH-16592 test leaking a message queue
NickSdot Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions Zend/tests/arginfo_zpp_mismatch.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,36 @@ if (getenv('SKIP_MSAN')) die("skip msan misses interceptors for some functions")

require __DIR__ . "/arginfo_zpp_mismatch.inc";

function testWeakSysvIpcFunction($function): bool {
if (!in_array($function, ['msg_queue_exists', 'msg_get_queue', 'sem_get', 'shm_attach'], true)) {
return false;
}

for ($argumentCount = 0; $argumentCount <= 8; $argumentCount++) {
$arguments = array_fill(0, $argumentCount, null);
if ($function === 'msg_queue_exists' && $argumentCount >= 1) {
$arguments[0] = 1;
}
if (($function === 'sem_get' || $function === 'shm_attach') && $argumentCount >= 3) {
$arguments[2] = 0600;
}

try {
$result = @$function(...$arguments);
if ($result instanceof SysvMessageQueue) {
msg_remove_queue($result);
} elseif ($result instanceof SysvSemaphore) {
sem_remove($result);
} elseif ($result instanceof SysvSharedMemory) {
shm_remove($result);
}
} catch (Throwable) {
}
}

return true;
}

function test($function) {
if (skipFunction($function)) {
return;
Expand All @@ -21,6 +51,10 @@ function test($function) {
} else {
echo "Testing " . get_class($function[0]) . "::$function[1]\n";
}
if (testWeakSysvIpcFunction($function)) {
ob_end_clean();
return;
}
try {
@$function();
} catch (Throwable) {
Expand Down
4 changes: 3 additions & 1 deletion ext/sysvmsg/tests/gh16592.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ class Test {
function __serialize() {}
}

$q = msg_get_queue(1);
// use a private queue, so we only remove our own.
$q = msg_get_queue(0, 0600);
try {
msg_send($q, 1, new Test, true);
} catch (\TypeError $e) {
echo $e->getMessage();
}
msg_remove_queue($q);
?>
--EXPECT--
Test::__serialize() must return an array
Loading