Refactor extension specific code out of Invoke-Tests.ps1

Author: shivammathur

extension/BuildPhpExtension/BuildPhpExtension.psd1

@@ -100,8 +100,13 @@
         'Invoke-Build',
         'Invoke-CleanupTempFiles',
         'Invoke-Tests',
+        'Set-AmqpTestEnvironment',
         'Set-GAGroup',
+        'Set-ImagickTestEnvironment',
         'Set-NetSecurityProtocolType',
+        'Set-Oci819TestEnvironment',
+        'Set-PdoOciTestEnvironment',
+        'Set-XdebugTestEnvironment',
 
         # Public functions
         'Invoke-PhpBuildExtension'

extension/BuildPhpExtension/private/Invoke-Tests.ps1

@@ -19,31 +19,15 @@ Function Invoke-Tests {
             $php_dir = Join-Path $currentDirectory php-bin
             $env:TEST_PHP_EXECUTABLE = "$php_dir\php.exe"
             $env:REPORT_EXIT_STATUS = 1
-            $env:XDEBUG_MODE = ""
-            $env:MAGICK_CONFIGURE_PATH = "$currentDirectory\..\deps\bin"
-            $env:PHP_AMQP_HOST="rabbitmq"
-            $env:PHP_AMQP_SSL_HOST="rabbitmq.example.org"
-            if($Config.name -eq 'pdo_oci') {
-                $env:TEST_WORKERS = 1
-                Get-PhpSrc -PhpVersion $Config.php_version
 
-                # This test is not compatible with Oracle XE
-                $testPath = "$currentDirectory\php-$($Config.php_version)-src\ext\pdo\tests\gh20553.phpt"
-                if (Test-Path $testPath) {
-                    Remove-Item $testPath -Force
-                }
-
-                $env:PDO_TEST_DIR = "$currentDirectory\php-$($Config.php_version)-src\ext\pdo\tests"
-                $env:PDO_OCI_TEST_DIR = "$currentDirectory\tests"
-                $env:PDO_OCI_TEST_USER = "system"
-                $env:PDO_OCI_TEST_PASS = "oracle"
-                $env:PDO_OCI_TEST_DSN = "oci:dbname=localhost:1521/XEPDB1.localdomain;charset=AL32UTF8"
-            }
-            if($Config.name -eq 'oci8_19'){
-                $env:PHP_OCI8_TEST_USER = "system"
-                $env:PHP_OCI8_TEST_PASS = "oracle"
-                $env:PHP_OCI8_TEST_DB = "localhost:1521/XEPDB1.localdomain"
+            # Set up extension-specific test environment
+            $extensionName = ($Config.name -replace '_(.)', { $_.Groups[1].Value.ToUpper() })
+            $extensionName = $extensionName.Substring(0,1).ToUpper() + $extensionName.Substring(1)
+            $cmdletName = "Set-${extensionName}TestEnvironment"
+            if (Get-Command $cmdletName -ErrorAction SilentlyContinue) {
+                & $cmdletName -Config $Config
             }
+
             $tempOriginal = $env:TEMP
             Get-TempFiles
             $type='extension'

extension/BuildPhpExtension/private/Set-AmqpTestEnvironment.ps1

@@ -0,0 +1,17 @@
+Function Set-AmqpTestEnvironment {
+    <#
+    .SYNOPSIS
+        Set up environment variables for AMQP extension tests
+    .PARAMETER Config
+        Extension Configuration
+    #>
+    [OutputType()]
+    param(
+        [Parameter(Mandatory = $true, Position=0, HelpMessage='Extension Configuration')]
+        [PSCustomObject] $Config
+    )
+    process {
+        $env:PHP_AMQP_HOST = "rabbitmq"
+        $env:PHP_AMQP_SSL_HOST = "rabbitmq.example.org"
+    }
+}

extension/BuildPhpExtension/private/Set-ImagickTestEnvironment.ps1

@@ -0,0 +1,17 @@
+Function Set-ImagickTestEnvironment {
+    <#
+    .SYNOPSIS
+        Set up environment variables for Imagick extension tests
+    .PARAMETER Config
+        Extension Configuration
+    #>
+    [OutputType()]
+    param(
+        [Parameter(Mandatory = $true, Position=0, HelpMessage='Extension Configuration')]
+        [PSCustomObject] $Config
+    )
+    process {
+        $currentDirectory = (Get-Location).Path
+        $env:MAGICK_CONFIGURE_PATH = "$currentDirectory\..\deps\bin"
+    }
+}

extension/BuildPhpExtension/private/Set-Oci819TestEnvironment.ps1

@@ -0,0 +1,18 @@
+Function Set-Oci819TestEnvironment {
+    <#
+    .SYNOPSIS
+        Set up environment variables for oci8_19 extension tests
+    .PARAMETER Config
+        Extension Configuration
+    #>
+    [OutputType()]
+    param(
+        [Parameter(Mandatory = $true, Position=0, HelpMessage='Extension Configuration')]
+        [PSCustomObject] $Config
+    )
+    process {
+        $env:PHP_OCI8_TEST_USER = "system"
+        $env:PHP_OCI8_TEST_PASS = "oracle"
+        $env:PHP_OCI8_TEST_DB = "localhost:1521/XEPDB1.localdomain"
+    }
+}

extension/BuildPhpExtension/private/Set-PdoOciTestEnvironment.ps1

@@ -0,0 +1,30 @@
+Function Set-PdoOciTestEnvironment {
+    <#
+    .SYNOPSIS
+        Set up environment variables for pdo_oci extension tests
+    .PARAMETER Config
+        Extension Configuration
+    #>
+    [OutputType()]
+    param(
+        [Parameter(Mandatory = $true, Position=0, HelpMessage='Extension Configuration')]
+        [PSCustomObject] $Config
+    )
+    process {
+        $currentDirectory = (Get-Location).Path
+        $env:TEST_WORKERS = 1
+        Get-PhpSrc -PhpVersion $Config.php_version
+
+        # This test is not compatible with Oracle XE
+        $testPath = "$currentDirectory\php-$($Config.php_version)-src\ext\pdo\tests\gh20553.phpt"
+        if (Test-Path $testPath) {
+            Remove-Item $testPath -Force
+        }
+
+        $env:PDO_TEST_DIR = "$currentDirectory\php-$($Config.php_version)-src\ext\pdo\tests"
+        $env:PDO_OCI_TEST_DIR = "$currentDirectory\tests"
+        $env:PDO_OCI_TEST_USER = "system"
+        $env:PDO_OCI_TEST_PASS = "oracle"
+        $env:PDO_OCI_TEST_DSN = "oci:dbname=localhost:1521/XEPDB1.localdomain;charset=AL32UTF8"
+    }
+}

extension/BuildPhpExtension/private/Set-XdebugTestEnvironment.ps1

@@ -0,0 +1,16 @@
+Function Set-XdebugTestEnvironment {
+    <#
+    .SYNOPSIS
+        Set up environment variables for Xdebug extension tests
+    .PARAMETER Config
+        Extension Configuration
+    #>
+    [OutputType()]
+    param(
+        [Parameter(Mandatory = $true, Position=0, HelpMessage='Extension Configuration')]
+        [PSCustomObject] $Config
+    )
+    process {
+        $env:XDEBUG_MODE = ""
+    }
+}