Skip missing PHP test directories

Author: shivammathur

php/BuildPhp/config/ext_test_directories

@@ -20,6 +20,7 @@ ext\soap\tests
 ext\spl\tests
 ext\sqlite3\tests
 ext\standard\tests
+ext\uri\tests
 ext\xmlreader\tests
 ext\xmlwriter\tests
 ext\xml\tests

php/BuildPhp/private/Get-TestsList.ps1

@@ -31,16 +31,32 @@ function Get-TestsList {
             $directories = Get-Content "$PSScriptRoot\..\config\${Type}_test_directories"
         }
 
-        foreach ($line in $directories) {
-            $path = "$line".Trim()
-            if ([string]::IsNullOrWhiteSpace($path)) {
-                continue
-            }
+        $testsFound = 0
+        $outputFilePath = $ExecutionContext.SessionState.Path.GetUnresolvedProviderPathFromPSPath($OutputFile)
+        $writer = [System.IO.StreamWriter]::new($outputFilePath, $false)
+        try {
+            foreach ($line in $directories) {
+                $path = "$line".Trim()
+                if ([string]::IsNullOrWhiteSpace($path)) {
+                    continue
+                }
+
+                if (-not (Test-Path -Path $path -PathType Container)) {
+                    Write-Host "Skipping missing test directory: $path"
+                    continue
+                }
 
-            $ttr = Get-ChildItem -Path $path -Filter "*.phpt" -Recurse
-            foreach ($t in $ttr) {
-                Add-Content $OutputFile $t.FullName
+                Get-ChildItem -Path $path -Filter "*.phpt" -Recurse | ForEach-Object {
+                    $testsFound++
+                    $writer.WriteLine($_.FullName)
+                }
             }
+        } finally {
+            $writer.Dispose()
+        }
+
+        if ($testsFound -eq 0) {
+            throw "No tests were found in the configured $Type test directories."
         }
     }
     end {