Add basic ability to pie install non-interactively

Author: asgrim

src/Command/CommandHelper.php

@@ -51,14 +51,15 @@
 /** @internal This is not public API for PIE, so should not be depended upon unless you accept the risk of BC breaks */
 final class CommandHelper
 {
-    public const ARG_REQUESTED_PACKAGE_AND_VERSION = 'requested-package-and-version';
-    public const OPTION_WITH_PHP_CONFIG            = 'with-php-config';
-    public const OPTION_WITH_PHP_PATH              = 'with-php-path';
-    public const OPTION_WITH_PHPIZE_PATH           = 'with-phpize-path';
-    public const OPTION_WORKING_DIRECTORY          = 'working-dir';
-    private const OPTION_MAKE_PARALLEL_JOBS        = 'make-parallel-jobs';
-    private const OPTION_SKIP_ENABLE_EXTENSION     = 'skip-enable-extension';
-    private const OPTION_FORCE                     = 'force';
+    public const ARG_REQUESTED_PACKAGE_AND_VERSION             = 'requested-package-and-version';
+    public const OPTION_WITH_PHP_CONFIG                        = 'with-php-config';
+    public const OPTION_WITH_PHP_PATH                          = 'with-php-path';
+    public const OPTION_WITH_PHPIZE_PATH                       = 'with-phpize-path';
+    public const OPTION_WORKING_DIRECTORY                      = 'working-dir';
+    public const OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL = 'allow-non-interactive-project-install';
+    private const OPTION_MAKE_PARALLEL_JOBS                    = 'make-parallel-jobs';
+    private const OPTION_SKIP_ENABLE_EXTENSION                 = 'skip-enable-extension';
+    private const OPTION_FORCE                                 = 'force';
 
     /** @psalm-suppress UnusedConstructor */
     private function __construct()
@@ -125,6 +126,13 @@ public static function configureDownloadBuildInstallOptions(Command $command, bo
 
         self::configurePhpConfigOptions($command);
 
+        $command->addOption(
+            self::OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL,
+            null,
+            InputOption::VALUE_NONE,
+            'When installing a PHP project, allow non-interactive project installations. Only used in certain contexts.',
+        );
+
         /**
          * Allows additional options for the `./configure` command to be passed here.
          * Note, this means you probably need to call {@see self::validateInput()} to validate the input manually...

src/Command/InstallExtensionsForProjectCommand.php

@@ -17,13 +17,15 @@
 use Php\Pie\Installing\InstallForPhpProject\FindMatchingPackages;
 use Php\Pie\Installing\InstallForPhpProject\InstallPiePackageFromPath;
 use Php\Pie\Installing\InstallForPhpProject\InstallSelectedPackage;
+use Php\Pie\Platform;
 use Php\Pie\Platform\InstalledPiePackages;
 use Php\Pie\Util\Emoji;
 use Psr\Container\ContainerInterface;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\QuestionHelper;
 use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\ConsoleOutputInterface;
 use Symfony\Component\Console\Output\NullOutput;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -123,6 +125,17 @@ public function execute(InputInterface $input, OutputInterface $output): int
             return $exit;
         }
 
+        $allowNonInteractive = $input->hasOption(CommandHelper::OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL) && $input->getOption(CommandHelper::OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL);
+        if (! Platform::isInteractive() && ! $allowNonInteractive) {
+            $output->writeln(sprintf(
+                '<warning>Aborting! You are not running in interactive mode, and --%s was not specified.</warning>',
+                CommandHelper::OPTION_ALLOW_NON_INTERACTIVE_PROJECT_INSTALL,
+            ));
+            // @todo more details
+
+            return Command::FAILURE;
+        }
+
         $targetPlatform = CommandHelper::determineTargetPlatformFromInputs($input, $output);
 
         $output->writeln(sprintf(
@@ -221,27 +234,45 @@ function (Link $link) use ($pieComposer, $phpEnabledExtensions, $installedPiePac
                     return;
                 }
 
-                $choiceQuestion = new ChoiceQuestion(
-                    "\nThe following packages may be suitable, which would you like to install: ",
-                    array_merge(
-                        ['None'],
-                        array_map(
-                            static function (array $match): string {
-                                return sprintf('%s: %s', $match['name'], $match['description'] ?? 'no description available');
-                            },
-                            $matches,
+                if (! Platform::isInteractive() && count($matches) > 1) {
+                    $anyErrorsHappened = true;
+
+                    // @todo Figure out if there is a way to improve this, safely
+                    $output->writeln(sprintf(
+                        "<warning>Multiple packages were found for %s:</warning>\n  %s\n\n<warning>This means you cannot `pie install` this project interactively for now.</warning>",
+                        $extension->nameWithExtPrefix(),
+                        implode("\n  ", array_column($matches, 'name')),
+                    ));
+
+                    return;
+                }
+
+                if (Platform::isInteractive()) {
+                    $choiceQuestion = new ChoiceQuestion(
+                        "\nThe following packages may be suitable, which would you like to install: ",
+                        array_merge(
+                            ['None'],
+                            array_map(
+                                static function (array $match): string {
+                                    return sprintf('%s: %s', $match['name'], $match['description'] ?? 'no description available');
+                                },
+                                $matches,
+                            ),
                         ),
-                    ),
-                    0,
-                );
+                        0,
+                    );
 
-                $selectedPackageAnswer = (string) $helper->ask($input, $output, $choiceQuestion);
+                    $selectedPackageAnswer = (string) $helper->ask($input, $output, $choiceQuestion);
 
-                if ($selectedPackageAnswer === 'None') {
-                    $output->writeln('Okay I won\'t install anything for ' . $extension->name());
-                    $anyErrorsHappened = true;
+                    if ($selectedPackageAnswer === 'None') {
+                        $output->writeln('Okay I won\'t install anything for ' . $extension->name());
+                        $anyErrorsHappened = true;
 
-                    return;
+                        return;
+                    }
+                    $selectedPackageName = substr($selectedPackageAnswer, 0, (int) strpos($selectedPackageAnswer, ':'));
+                } else {
+                    $selectedPackageName = $matches[0]['name'];
                 }
 
                 $requestInstallConstraint = '';
@@ -250,8 +281,12 @@ static function (array $match): string {
                 }
 
                 try {
+                    $output->writeln(
+                        sprintf('Invoking pie install of %s%s', $selectedPackageName, $requestInstallConstraint),
+                        OutputInterface::VERBOSITY_VERBOSE,
+                    );
                     $this->installSelectedPackage->withPieCli(
-                        substr($selectedPackageAnswer, 0, (int) strpos($selectedPackageAnswer, ':')) . $requestInstallConstraint,
+                        $selectedPackageName . $requestInstallConstraint,
                         $input,
                         $output,
                     );