Skip to content

Commit 5e2de67

Browse files
committed
Fix two tests when run on macos/alpine
1 parent 02e42dc commit 5e2de67

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

test/unit/Downloading/DownloadUrlMethodTest.php

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,13 @@ public function testPrePackagedBinaryDownloads(): void
145145

146146
self::assertSame(DownloadUrlMethod::PrePackagedBinary, $downloadUrlMethod);
147147

148+
// TargetPlatform doesn't have the libc specified, so the assertion needs to be made
149+
// against the test machine's libc
150+
$libc = $targetPlatform->libcFlavour()->value;
148151
self::assertSame(
149152
[
150-
'php_bar-1.2.3_php8.3-x86_64-linux-glibc-debug-zts.zip',
151-
'php_bar-1.2.3_php8.3-x86_64-linux-glibc-debug-zts.tgz',
153+
'php_bar-1.2.3_php8.3-x86_64-linux-' . $libc . '-debug-zts.zip',
154+
'php_bar-1.2.3_php8.3-x86_64-linux-' . $libc . '-debug-zts.tgz',
152155
'php_bar-1.2.3_php8.3-x86_64-linux-anylibc-debug-zts.zip',
153156
'php_bar-1.2.3_php8.3-x86_64-linux-anylibc-debug-zts.tgz',
154157
],
@@ -223,12 +226,15 @@ public function testMultipleDownloadUrlMethods(): void
223226

224227
$firstMethod = $downloadUrlMethods[0];
225228
self::assertSame(DownloadUrlMethod::PrePackagedBinary, $firstMethod);
229+
// TargetPlatform doesn't have the libc specified, so the assertion needs to be made
230+
// against the test machine's libc
231+
$libc = $targetPlatform->libcFlavour()->value;
226232
self::assertSame(
227233
[
228-
'php_bar-1.2.3_php8.3-x86_64-linux-glibc-debug.zip',
229-
'php_bar-1.2.3_php8.3-x86_64-linux-glibc-debug.tgz',
230-
'php_bar-1.2.3_php8.3-x86_64-linux-glibc-debug-nts.zip',
231-
'php_bar-1.2.3_php8.3-x86_64-linux-glibc-debug-nts.tgz',
234+
'php_bar-1.2.3_php8.3-x86_64-linux-' . $libc . '-debug.zip',
235+
'php_bar-1.2.3_php8.3-x86_64-linux-' . $libc . '-debug.tgz',
236+
'php_bar-1.2.3_php8.3-x86_64-linux-' . $libc . '-debug-nts.zip',
237+
'php_bar-1.2.3_php8.3-x86_64-linux-' . $libc . '-debug-nts.tgz',
232238
'php_bar-1.2.3_php8.3-x86_64-linux-anylibc-debug.zip',
233239
'php_bar-1.2.3_php8.3-x86_64-linux-anylibc-debug.tgz',
234240
'php_bar-1.2.3_php8.3-x86_64-linux-anylibc-debug-nts.zip',

0 commit comments

Comments
 (0)