Skip to content

Commit 9a20a16

Browse files
authored
Merge pull request #619 from iliaal/fix/unzip-build-tool
Add unzip to required build tools
2 parents c9e57c5 + 1487f08 commit 9a20a16

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

src/SelfManage/BuildTools/CheckAllBuildTools.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,25 @@ public static function buildToolsFactory(): self
7070
PackageManager::Brew->value => 'libtool',
7171
],
7272
),
73+
// Composer's archive downloader uses /usr/bin/unzip first
74+
// and falls back to git-source-cloning when it isn't
75+
// present (not to PHP's ZipArchive). Without unzip, a
76+
// pre-packaged-binary dist URL is silently swapped for a
77+
// git clone of the source tree and the .so the user paid
78+
// for in download time is never extracted, surfacing as
79+
// ExtensionBinaryNotFound when PIE's prePackagedBinary
80+
// check looks for it in the vendor dir. Bare php:X.Y-cli
81+
// Debian images do not ship /usr/bin/unzip.
82+
new BinaryBuildToolFinder(
83+
'unzip',
84+
[
85+
PackageManager::Apt->value => 'unzip',
86+
PackageManager::Apk->value => 'unzip',
87+
PackageManager::Dnf->value => 'unzip',
88+
PackageManager::Yum->value => 'unzip',
89+
PackageManager::Brew->value => 'unzip',
90+
],
91+
),
7392
new PhpizeBuildToolFinder(
7493
[
7594
PackageManager::Apt->value => 'php-dev',

0 commit comments

Comments
 (0)