Shrink baseline after fallback verification moved into lib

Author: asgrim

phpstan-baseline.neon

@@ -438,48 +438,6 @@ parameters:
 			count: 1
 			path: src/SelfManage/Update/FetchPieReleaseFromGitHub.php
 
-		-
-			message: '#^Cannot access offset ''extensions'' on array\|false\.$#'
-			identifier: offsetAccess.nonOffsetAccessible
-			count: 1
-			path: src/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php
-
-		-
-			message: '#^Cannot access offset ''issuer'' on array\|false\.$#'
-			identifier: offsetAccess.nonOffsetAccessible
-			count: 2
-			path: src/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php
-
-		-
-			message: '#^Cannot access offset ''subject'' on array\|false\.$#'
-			identifier: offsetAccess.nonOffsetAccessible
-			count: 1
-			path: src/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php
-
-		-
-			message: '#^Parameter \#1 \$callback of function array_map expects \(callable\(mixed\)\: mixed\)\|null, Closure\(array\)\: Php\\Pie\\SelfManage\\Verify\\Attestation given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php
-
-		-
-			message: '#^Parameter \#1 \$issuer of static method Php\\Pie\\SelfManage\\Verify\\FailedToVerifyRelease\:\:fromIssuerCertificateVerificationFailed\(\) expects array\<string, string\>\|string, mixed given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php
-
-		-
-			message: '#^Parameter \#1 \$issuer of static method Php\\Pie\\SelfManage\\Verify\\FailedToVerifyRelease\:\:fromNoIssuerCertificateInTrustedRoot\(\) expects array\<string, string\>\|string, mixed given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php
-
-		-
-			message: '#^Parameter \#1 \$string of function trim expects string, string\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/SelfManage/Verify/FallbackVerificationUsingOpenSsl.php
-
 		-
 			message: '#^Dead catch \- Php\\Pie\\SelfManage\\Verify\\GithubCliNotAvailable is never thrown in the try block\.$#'
 			identifier: catch.neverThrown

test/unit/SelfManage/Verify/FallbackVerificationUsingOpenSslTest.php

@@ -65,7 +65,7 @@ public function setUp(): void
         $this->output         = new BufferedOutput();
 
         $trustedRootFilePath = tempnam(sys_get_temp_dir(), 'pie_test_trusted_root_file_path');
-        assert(is_string($trustedRootFilePath) && $trustedRootFilePath !== '');
+        assert(is_string($trustedRootFilePath));
         $this->trustedRootFilePath = $trustedRootFilePath;
 
         $this->verifier = new FallbackVerificationUsingOpenSsl(new VerifyAttestationWithOpenSsl($this->trustedRootFilePath, self::TEST_GITHUB_URL, $this->httpDownloader, $this->authHelper));