Skip to content

Add unzip to required build tools #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 1 commit into
base: 1.5.x
Choose a base branch
from
+19 −0
Open

Add unzip to required build tools #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/SelfManage/BuildTools/CheckAllBuildTools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,25 @@ public static function buildToolsFactory(): self
PackageManager::Brew->value => 'libtool',
],
),
// Composer's archive downloader uses /usr/bin/unzip first
// and falls back to git-source-cloning when it isn't
// present (not to PHP's ZipArchive). Without unzip, a
// pre-packaged-binary dist URL is silently swapped for a
// git clone of the source tree and the .so the user paid
// for in download time is never extracted, surfacing as
// ExtensionBinaryNotFound when PIE's prePackagedBinary
// check looks for it in the vendor dir. Bare php:X.Y-cli
// Debian images do not ship /usr/bin/unzip.
new BinaryBuildToolFinder(
'unzip',
[
PackageManager::Apt->value => 'unzip',
PackageManager::Apk->value => 'unzip',
PackageManager::Dnf->value => 'unzip',
PackageManager::Yum->value => 'unzip',
PackageManager::Brew->value => 'unzip',
],
),
new PhpizeBuildToolFinder(
[
PackageManager::Apt->value => 'php-dev',
Expand Down
Loading