Better missing logo handling

Author: Mark Randall

index.php

@@ -270,7 +270,10 @@ function drawBranchInfo(PointReleaseData $release): void
                     <div class="landing-lrv-inner-padding" >
                         <div class="landing-lrv-inner">
                             <div>
-                                <img src="<?= safe($latestVersion->logoUrl) ?>" alt="php" style="height: 100px; width: 100%; object-fit: contain; margin-left: auto; margin-right: auto">
+                                <?php if ($latestVersion->logoUrl) { ?>
+                                    <img src="<?= safe($latestVersion->logoUrl) ?>" alt="php" style="height: 100px; width: 100%; object-fit: contain; margin-left: auto; margin-right: auto">
+                                <?php } ?>
+
                                 <div style="text-align: center; margin-top: 1em; color: white">
                                     <?php drawBranchInfo($latestVersion->latestRelease) ?>
                                 </div>

releases/8.5/header.inc

@@ -9,7 +9,10 @@ function drawVersionHeader(VersionData $version, string $title, string $subtitle
     echo SuperBanner::renderBanner(Util::bufferOutput(function () use ($version, $title, $subtitle) {
         ?>
         <div style="text-align: center; display: flex; flex-direction: column; gap: 1em">
-            <img src="<?= safe($version->logoUrl) ?>" style="width: 100%; height: 80px; object-fit: contain"/>
+            <?php if ($version->logoUrl) { ?>
+                <img alt="Logo for PHP <?= safe($version->label) ?>" src="<?= safe($version->logoUrl) ?>" style="width: 100%; height: 80px; object-fit: contain"/>
+            <?php } ?>
+
             <div>
 
                 <div style="font-size: 35px; margin-top: 1em; font-weight: 500"><?= safe($title) ?></div>

src/Releases/VersionData.php

@@ -51,6 +51,7 @@ final class VersionData
     private ?DateTimeImmutable $_releaseDate = null;
     private ?array $_pointReleases = null;
     private ?array $_highlightSnippets = null;
+    private ?string $_logoCache = null;
 
     public function __construct(public readonly string $label)
     {
@@ -242,8 +243,16 @@ public static function all(): array
         })();
     }
 
+    /**
+     * Returns the current logo url or an empty string
+     *
+     * todo: Move these to the data directory
+     */
     public string $logoUrl {
-        get => '/images/php8/logo_php' . $this->majorVersion . '_' . $this->minorVersion . '.svg';
+        get => $this->_logoCache ??= (function() {
+            $path = '/images/php' . $this->majorVersion . '/logo_php' . $this->majorVersion . '_' . $this->minorVersion . '.svg';
+            return file_exists(ProjectGlobals::getProjectRoot() . $path) ? $path : null;
+        })();
     }
 
     public ?string $aboutPageURL {