Depreciate get_current_release_for_branch, swap over

Author: markrandall

bin/bumpRelease

@@ -17,7 +17,7 @@ $major = (int) $_SERVER['argv'][1];
 isset($RELEASES[$major]) or die("Unknown major version $major");
 $minor = isset($_SERVER['argv'][2]) ? (int) $_SERVER['argv'][2] : null;
 
-$version = Branches::get_current_release_for_branch($major, $minor);
+$version = Branches::getCurrentReleaseForBranch($major, $minor);
 $info = $RELEASES[$major][$version] ?? null;
 
 if ($info === null) {

include/branches.inc

@@ -400,6 +400,7 @@ function version_array(string $version, ?int $length = null)
     return $versionArray;
 }
 
+#[Deprecated('Use Branches::getCurrentReleaseForBranch')]
 function get_current_release_for_branch(int $major, ?int $minor): ?string {
     global $RELEASES, $OLDRELEASES;
 

src/Releases/Branches.php

@@ -434,7 +434,7 @@ public static function getBranchSupportStatus(string $branch): ?string
         return null;
     }
 
-    public static function get_current_release_for_branch(int $major, ?int $minor): ?string
+    public static function getCurrentReleaseForBranch(int $major, ?int $minor): ?string
     {
         $GLOBAL_RELEASES = self::getReleaseData();
         $GLOBAL_OLDRELEASES = self::getOldReleaseData();

tests/Unit/Releases/LegacyReleaseHelpersTest.php

@@ -172,7 +172,7 @@ public function testCurrentReleaseForBranch(): void
         /* need something that won't change in response to new releases */
         self::assertEquals(
             '7.4.33',
-            Branches::get_current_release_for_branch(7, 4),
+            Branches::getCurrentReleaseForBranch(7, 4),
         );
     }
 }