refactor: remove error suppression operator (@) and add proper error handling

Replace error suppression operator (@) with explicit file existence and readability checks. Add new helper functions in include/file.inc (file_get_size, file_get_mtime, file_get_contents_if_exists) to safely handle file operations. This improves code reliability by catching actual errors rather than silencing them, and makes error handling explicit and testable throughout the codebase.

Author: jordikroon

bin/news2html

@@ -11,7 +11,7 @@ if (count($_SERVER['argv']) < 2) {
 }
 $news_file = array_shift($_SERVER['argv']);
 $version = array_shift($_SERVER['argv']);
-$changelog = @array_shift($_SERVER['argv']);
+$changelog = array_shift($_SERVER['argv']);
 
 // find NEWS entry
 $fp = fopen($news_file, "r");

cal.php

@@ -253,8 +253,11 @@ function display_events_for_day($day, $events): void
 // Find a single event in the events file by ID
 function load_event($id)
 {
+    $path = "backend/events.csv";
+    if (!file_exists($path) || !is_readable($path)) { return false; }
+
     // Open events CSV file, return on error
-    $fp = @fopen("backend/events.csv",'r');
+    $fp = fopen($path,'r');
     if (!$fp) { return false; }
 
     // Read as we can, event by event
@@ -289,7 +292,10 @@ function load_events($from, $whole_month = false)
     $events = $seen = [];
 
     // Try to open the events file for reading, return if unable to
-    $fp = @fopen("backend/events.csv",'r');
+    $path = "backend/events.csv";
+    if (!file_exists($path) || !is_readable($path)) { return false; }
+
+    $fp = fopen($path,'r');
     if (!$fp) { return false; }
 
     // For all events, read in the event and check it if fits our scope
@@ -357,7 +363,9 @@ function read_event($fp)
     ] = $linearr;
 
     // Get info on recurring event
-    @[$recur, $recur_day] = explode(":", $recur, 2);
+    $recurParts = explode(":", $recur, 2);
+    $recur = $recurParts[0];
+    $recur_day = $recurParts[1] ?? null;
 
     // Return with SQL-resultset like array
     return [

download-docs.php

@@ -114,8 +114,8 @@
             $link_to = "/distributions/manual/$filename";
 
             // Try to get size and changed date
-            $size = @filesize($filepath);
-            $changed = @filemtime($filepath);
+            $size = file_get_size($filepath);
+            $changed = file_get_size($filepath);
 
             // Size available, collect information
             if ($size !== false) {
@@ -138,8 +138,8 @@
 $actual_file = $_SERVER['DOCUMENT_ROOT'] . "/distributions/manual/php_manual_chm.zip";
 if (file_exists($actual_file)) {
     $link_to = "/get/php_manual_chm.zip/from/a/mirror";
-    $size    = @filesize($actual_file);
-    $changed = @filemtime($actual_file);
+    $size    = file_get_size($actual_file);
+    $changed = filemtime($actual_file);
     if ($size !== FALSE) {
         $files["en"]["zip"] = array(
             $link_to,

images/elephpants.php

@@ -47,7 +47,7 @@
 
 // read out photo metadata
 $path = __DIR__ . '/elephpants';
-$json = @file_get_contents($path . '/flickr.json');
+$json = file_get_contents_if_exists($path . '/flickr.json');
 $photos = json_decode($json, true);
 
 // if no photo data, respond with an error.

include/do-download.inc

@@ -14,7 +14,7 @@ function get_actual_download_file($file)
     // Find out what is the exact file requested
     $found = false;
     foreach ($possible_files as $name => $log) {
-        if (@file_exists($_SERVER['DOCUMENT_ROOT'] . '/distributions/' . $name)) {
+        if (file_exists($_SERVER['DOCUMENT_ROOT'] . '/distributions/' . $name)) {
             $found = $name;
             break;
         }

include/download-instructions/windows-downloads.php

@@ -1,7 +1,7 @@
 <?php
 $baseDownloads  = 'https://downloads.php.net/~windows/releases/archives/';
 
-$dataStr = @file_get_contents(__DIR__ . '/../../backend/win-releases.json');
+$dataStr = file_get_contents_if_exists(__DIR__ . '/../../backend/win-releases.json');
 $releases = $dataStr ? json_decode($dataStr, true) : null;
 
 if (!is_array($releases)) {

include/file.inc

@@ -0,0 +1,35 @@
+<?php
+
+/*
+ *
+*/
+
+function file_get_size(string $filename): int|false
+{
+    if (!file_exists($filename) || !is_readable($filename)) {
+        return false;
+    }
+
+    return filesize($filename);
+}
+
+function file_get_mtime(string $filename): int|false
+{
+    if (!file_exists($filename) || !is_readable($filename)) {
+        return false;
+    }
+
+    return filemtime($filename);
+}
+
+function file_get_contents_if_exists(string $filename): string|false
+{
+    if (!file_exists($filename) || !is_readable($filename)) {
+        return false;
+    }
+
+    return file_get_contents($filename);
+}
+{
+
+}

include/footer.inc

@@ -101,14 +101,14 @@ if (!empty($_SERVER['BASE_PAGE'])
  $jsfiles = ["ext/jquery-3.6.0.min.js", "ext/FuzzySearch.min.js", "ext/mousetrap.min.js", "ext/jquery.scrollTo.min.js", "search.js", "common.js"];
  foreach ($jsfiles as $filename) {
    $path = dirname(__DIR__) . '/js/' . $filename;
-   echo '<script src="/cached.php?t=' . @filemtime($path) . '&amp;f=/js/' . $filename . '"></script>' . "\n";
+   echo '<script src="/cached.php?t=' . filemtime($path) . '&amp;f=/js/' . $filename . '"></script>' . "\n";
  }
 ?>
 <?php
  $jsfiles = ["interactive-examples.js"];
  foreach ($jsfiles as $filename) {
    $path = dirname(__DIR__) . '/js/' . $filename;
-   echo '<script type="module" src="/cached.php?t=' . @filemtime($path) . '&amp;f=/js/' . $filename . '"></script>' . "\n";
+   echo '<script type="module" src="/cached.php?t=' . filemtime($path) . '&amp;f=/js/' . $filename . '"></script>' . "\n";
  }
 ?>
 

include/get-download.inc

@@ -18,7 +18,7 @@ $site_config = [
 // Find out what is the exact file requested
 $file = false;
 foreach ($possible_files as $name) {
-    if (@file_exists($_SERVER['DOCUMENT_ROOT'] . '/distributions/' . $name)) {
+    if (file_exists($_SERVER['DOCUMENT_ROOT'] . '/distributions/' . $name)) {
         $file = $name;
         break;
     }
@@ -43,7 +43,7 @@ EOT;
     // Set local file name
     $local_file = $_SERVER['DOCUMENT_ROOT'] . '/distributions/' . $file;
     // Try to get filesize to display
-    $size = @filesize($local_file);
+    $size = file_get_size($local_file);
 }
 ?>
 </div>

include/header.inc

@@ -20,14 +20,14 @@ foreach($css_files as $filename) {
         $filename = "/styles/$filename";
     }
     $path = dirname(__DIR__) . $filename;
-    $CSS[$filename] = @filemtime($path);
+    $CSS[$filename] = filemtime($path);
 }
 
 $JS = [];
 if (isset($config["js_files"])) {
     foreach($config['js_files'] as $filename) {
         $path = dirname(__DIR__) . '/' . $filename;
-        $JS[$filename] = @filemtime($path);
+        $JS[$filename] = filemtime($path);
     }
 }