Skip to content

Link to installation documentation and Windows downloads #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimwins merged 2 commits into from
Sep 24, 2024
Merged

Link to installation documentation and Windows downloads #1076

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30f07eb
Link to installation documentation and Windows downloads
jimwins Sep 18, 2024
e522201
Add <h1>, fix manual links to remove language
jimwins Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions downloads.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,30 @@
],
);
?>
<p>
<a href="/manual/en/install.general.php">Installing PHP</a> is covered
thoroughly in the PHP documentation.
</p>
Comment thread
cmb69 marked this conversation as resolved.

<h2>Binaries</h2>

<p>
<a href="https://windows.php.net/download/">Binaries are available for
Copy link
Copy Markdown
Member

@NattyNarwhal NattyNarwhal Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably remove the Windows download links below if we link it up here.

Copy link
Copy Markdown
Member Author

@jimwins jimwins Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not worried about the redundancy, and the later links go to the specific #id for the corresponding version.

Microsoft Windows</a>. The PHP project does not currently release binary packages
for other platforms such as Linux or macOS, but they are packaged by distributions
and other providers. For more information, see:
Copy link
Copy Markdown
Member

@NattyNarwhal NattyNarwhal Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be mentioning them here perhaps?

Copy link
Copy Markdown
Member Author

@jimwins jimwins Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean by "them".

Copy link
Copy Markdown
Member

@NattyNarwhal NattyNarwhal Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distributions for PHP from third parties.

Copy link
Copy Markdown
Member Author

@jimwins jimwins Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to link from this page to those, but I hope we can get agreement to start putting some of that sort of information in the documentation.


<ul>
<li>
<a href="/manual/en/install.unix.php">Installation instructions for Unix systems</a>
Copy link
Copy Markdown
Member

@cmb69 cmb69 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the installation instructions for Unix refer to manual builds. I think only https://www.php.net/manual/en/install.unix.debian.php is about packages. Besides that page needs an overhaul, we should at least have a respective page about Fedora/RHEL packages (yum). Maybe @remicollet is interested in this?

Copy link
Copy Markdown
Member Author

@jimwins jimwins Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can at least have a unix.yum that corresponds to unix.debian without much controversy, I hope, and then actually link to the more comprehensive third-party repositories if we decide to start calling out the third-party things.

Copy link
Copy Markdown
Member

@NattyNarwhal NattyNarwhal Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Debian page could mention Ubuntu too (and maybe mention i.e. Ondrej's repo since it covers more versions than the Debian/Ubuntu packages?).

</li>
<li>
<a href="/manual/en/install.macosx.php">Installation instructions for macOS</a>
Copy link
Copy Markdown
Member

@cmb69 cmb69 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe directly link to https://www.php.net/manual/install.macosx.packages.php?

Copy link
Copy Markdown
Member Author

@jimwins jimwins Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to link to the install page for macOS and Unix instead of direct to the packages, just to not push users too deep into the weeds. Those pages in the documentation should be cleaned up to put information about downloading binaries/packages before instructions on building from source.

</li>
</ul>
</p>

<h2>Source Code</h2>
<?php $i = 0; foreach ($RELEASES as $MAJOR => $major_releases): /* major releases loop start */
$releases = array_slice($major_releases, 0, $SHOW_COUNT);
?>
Expand Down