Add alt text to Elephants images#1292
Merged
sy-records merged 2 commits intophp:masterfrom Jul 11, 2025
Merged
Conversation
Fixing elements which do not have alt attributes
adamcable
requested review from
saundefined,
sgolemon and
sy-records
as code owners
Contributor
|
🚀 Regression report for commit 522c73a is at https://web-php-regression-report-pr-1292.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit 522c73a can be found at https://web-php-pr-1292.preview.thephp.foundation |
Member
|
I'm not sure that just reusing the titles (which are apparently the file names) as alt text makes sense; that might actually be worse than having no alt texts at all. As is, a screen reader likely ignores the images, but now it may read: "DSC_0031" … |
Contributor
Author
|
Yes - setting alt text to empty sounds better. And just makes sure it keeps to image alt text best practices |
Member
|
@cmb69 Hi, This doesn't seem to be a file name?
|
Contributor
Author
|
On live some are...
|
sy-records
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing elements which do not have alt attributes