Skip to content

Unify design of all release pages #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theodorejb wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Unify design of all release pages #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3abe40d
Use PHP 8.5 styling for all release pages
theodorejb Nov 14, 2025
292c7b2
Clean up dead and duplicate styles
theodorejb Jun 10, 2026
1dbc5f3
Correctly style code in PHP 8.5 headings
theodorejb Jun 10, 2026
2b1926d
Attempt screenshots fix
theodorejb Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ export default defineConfig({
workers: process.env.CI ? 1 : undefined,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: 'html',
expect: {
toHaveScreenshot: {
animations: 'disabled',
},
},
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
use: {
/* Base URL to use in actions like `await page.goto('/')`. */
Expand Down
38 changes: 12 additions & 26 deletions releases/8.0/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,22 @@
];

function common_header(string $description): void {
global $MYSITE;
global $MYSITE, $lang;

$meta_image_path = \htmlspecialchars(
\filter_var($MYSITE . 'images/php8/php_8_released.png', \FILTER_VALIDATE_URL));
$meta_description = \htmlspecialchars($description);

\site_header("PHP 8.0.0 Release Announcement", [
'current' => 'php8',
'css' => ['php8.css'],
$languages = [];
foreach (LANGUAGES as $code => $text) {
$languages[] = ['name' => $text, 'selected' => $lang === $code, 'url' => '/releases/8.0/' . $code . '.php'];
}

\site_header("PHP 8.0 Release Announcement", [
'current' => 'php85',
'css' => ['php85.css'],
'language_switcher' => $languages,
'theme_switcher' => true,
'meta_tags' => <<<META
<meta name="twitter:card" content="summary_large_image" />
<meta name="twitter:site" content="@official_php" />
Expand All @@ -49,28 +56,7 @@ function common_header(string $description): void {
]);
}

function language_chooser(string $currentLang): void {
// Print out the form with all the options
echo '
<form action="" method="get" id="changelang" name="changelang">
<fieldset>
<label for="changelang-langs">Change language:</label>
<select onchange="location = this.value + \'.php\'" name="lang" id="changelang-langs">
';

$tab = ' ';
foreach (LANGUAGES as $lang => $text) {
$selected = ($lang === $currentLang) ? ' selected="selected"' : '';
echo $tab, "<option value='$lang'$selected>$text</option>\n";
}

echo ' </select>
</fieldset>
</form>
';
}

function message($code, $language = 'en')
function message($code, $language = 'en'): string
{
$original = require __DIR__ . '/languages/en.php';
if (($language !== 'en') && file_exists(__DIR__ . '/languages/' . $language . '.php')) {
Expand Down
Loading
Loading