Create UserNoteService class#710
Closed
kamil-tekiela wants to merge 1 commit into
Closed
Conversation
Member
|
This seems to have a conflict now. Would you be willing to address that? |
kamil-tekiela
force-pushed
the
UserNoteService
branch
from
November 29, 2023 17:43
87d67eb to
dffe159
Compare
Member
|
It still has conflicts, or maybe again? |
kamil-tekiela
force-pushed
the
UserNoteService
branch
from
December 7, 2023 14:48
dffe159 to
7b07ad0
Compare
Member
Author
|
@derickr Rebased again. |
kamil-tekiela
force-pushed
the
UserNoteService
branch
from
December 18, 2023 12:35
7b07ad0 to
b2d1e63
Compare
Contributor
|
🚀 Commit 36538ee Deployed on https://web-php-pr-710.preview.thephp.foundation |
Member
|
It still has conflicts, or maybe again? (sorry, I keep missing the updates) |
Member
|
@kamil-tekiela, I am closing this PR as part of the clean up. Please feel free to reopen and update it if it is still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves user note related functionality to a dedicated class. This helps with code organization. Only a very minimal refactoring was done to help with PR reviewing; it was mostly copy-paste.