[BUGFIX] Read project version from the DOM so "0.10" is not coerced to 0.1

A <project version="0.10"> in guides.xml was rendered as version 0.1
(title, objects.inv, every |version| substitution). XmlFileLoader parses
guides.xml with XmlUtils::convertDomElementToArray(), which runs phpize() on
every attribute value, coercing version-like strings into numbers: "0.10"
becomes the float 0.1, "1.0" becomes 1, "13.0" becomes 13.

Read the <project> attributes (all strings) straight from the DOM, and detach
the element before the conversion so phpize never sees them. The version is now
read correctly at the source instead of being coerced and patched up afterwards.

This makes the previous "escaped version" workaround obsolete -- writing
version="'3.0'" with single quotes to dodge phpize, with a beforeNormalization
that stripped them again -- so it is removed; write the version directly, e.g.
version="0.10".

Reported on docs.typo3.org for netresearch/nr-vault and nr-llm (0.10 / 0.12).

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>

Author: CybotTM

packages/guides-cli/src/Config/XmlFileLoader.php

@@ -13,6 +13,8 @@
 
 namespace phpDocumentor\Guides\Cli\Config;
 
+use DOMAttr;
+use DOMElement;
 use Symfony\Component\Config\Loader\FileLoader;
 use Symfony\Component\Config\Util\Exception\XmlParsingException;
 use Symfony\Component\Config\Util\XmlUtils;
@@ -36,9 +38,34 @@ public function load(mixed $resource, string|null $type = null): array
             throw new XmlParsingException(sprintf('The XML file "%s" is not valid.', $resource));
         }
 
+        // The <project> attributes (title, version, release, copyright) are all
+        // strings and are read from the DOM directly. XmlUtils::convertDomElementToArray()
+        // below runs phpize() on every attribute value, which coerces version-like
+        // strings into numbers ("0.10" would become the float 0.1, "1.0" would
+        // become 1). Reading them with getAttribute() and detaching <project>
+        // beforehand keeps the version exactly as written.
+        $projectConfig = null;
+        $project = $element->getElementsByTagName('project')->item(0);
+        if ($project instanceof DOMElement) {
+            $projectConfig = [];
+            foreach ($project->attributes as $attribute) {
+                if (!($attribute instanceof DOMAttr)) {
+                    continue;
+                }
+
+                $projectConfig[$attribute->name] = $attribute->value;
+            }
+
+            $project->parentNode?->removeChild($project);
+        }
+
         $rootConfig = XmlUtils::convertDomElementToArray($element);
         assert(is_array($rootConfig));
 
+        if ($projectConfig !== null) {
+            $rootConfig['project'] = $projectConfig;
+        }
+
         $configs = [];
         if (isset($rootConfig['import'])) {
             foreach ((array) $rootConfig['import'] as $import) {

packages/guides/src/DependencyInjection/GuidesExtension.php

@@ -43,11 +43,8 @@
 use function assert;
 use function dirname;
 use function is_array;
-use function is_int;
 use function is_string;
 use function pathinfo;
-use function trim;
-use function var_export;
 
 final class GuidesExtension extends Extension implements CompilerPassInterface, ConfigurationInterface, PrependExtensionInterface
 {
@@ -64,42 +61,8 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->arrayNode('project')
                     ->children()
                         ->scalarNode('title')->end()
-                        ->scalarNode('version')
-                            ->beforeNormalization()
-                            ->always(
-                                // We need to revert the phpize call in XmlUtils. Version is always a string!
-                                static function ($value) {
-                                    if (!is_int($value) && !is_string($value)) {
-                                        return var_export($value, true);
-                                    }
-
-                                    if (is_string($value)) {
-                                        return trim($value, "'");
-                                    }
-
-                                    return $value;
-                                },
-                            )
-                            ->end()
-                        ->end()
-                        ->scalarNode('release')
-                            ->beforeNormalization()
-                            ->always(
-                            // We need to revert the phpize call in XmlUtils. Version is always a string!
-                                static function ($value) {
-                                    if (!is_int($value) && !is_string($value)) {
-                                        return var_export($value, true);
-                                    }
-
-                                    if (is_string($value)) {
-                                        return trim($value, "'");
-                                    }
-
-                                    return $value;
-                                },
-                            )
-                            ->end()
-                        ->end()
+                        ->scalarNode('version')->end()
+                        ->scalarNode('release')->end()
                         ->scalarNode('copyright')->end()
                     ->end()
                 ->end()

tests/Integration/tests/meta/version-from-guides-xml/input/guides.xml

@@ -6,7 +6,7 @@
 >
     <project
             title="Render guides"
-            version="'3.0'"
+            version="3.0"
             release="3.0.0"
     />
 </guides>