Keep version strings like "0.10" intact when loading guides.xml

CybotTM · CybotTM · commit fcc475cfe153 · 2026-06-17T00:01:26.000+02:00
guides.xml is parsed with Symfony XmlUtils::convertDomElementToArray(), which
runs phpize() on every attribute value, coercing numeric-looking strings to
numbers. A &lt;project version="0.10"&gt; therefore became the float 0.1 ("1.0" -&gt; 1,
"1.10" -&gt; 1.1, "13.0" -&gt; 13), so the project version and release rendered as
"0.1" everywhere -- breaking version switchers and deployments that distinguish
0.1 from 0.10.

The &lt;project&gt; attributes (title, version, release, copyright) are all strings,
so restore them verbatim from the DOM after the array conversion.

Reported on docs.typo3.org for netresearch/nr-vault and nr-llm (0.10 / 0.12).

Signed-off-by: Sebastian Mendel &lt;info@sebastianmendel.de&gt;
diff --git a/packages/guides-cli/src/Config/XmlFileLoader.php b/packages/guides-cli/src/Config/XmlFileLoader.php
@@ -13,6 +13,8 @@
 
 namespace phpDocumentor\Guides\Cli\Config;
 
+use DOMAttr;
+use DOMElement;
 use Symfony\Component\Config\Loader\FileLoader;
 use Symfony\Component\Config\Util\Exception\XmlParsingException;
 use Symfony\Component\Config\Util\XmlUtils;
@@ -39,6 +41,22 @@ public function load(mixed $resource, string|null $type = null): array
         $rootConfig = XmlUtils::convertDomElementToArray($element);
         assert(is_array($rootConfig));
 
+        // XmlUtils::convertDomElementToArray() runs phpize() on every attribute
+        // value, which turns version-like strings into numbers: "0.10" becomes
+        // the float 0.1, "1.0" becomes 1. The <project> attributes (title,
+        // version, release, copyright) are all strings, so restore them verbatim
+        // from the DOM to keep their exact value.
+        $project = $element->getElementsByTagName('project')->item(0);
+        if ($project instanceof DOMElement && isset($rootConfig['project']) && is_array($rootConfig['project'])) {
+            foreach ($project->attributes as $attribute) {
+                if (!$attribute instanceof DOMAttr) {
+                    continue;
+                }
+
+                $rootConfig['project'][$attribute->name] = $attribute->value;
+            }
+        }
+
         $configs = [];
         if (isset($rootConfig['import'])) {
             foreach ((array) $rootConfig['import'] as $import) {
diff --git a/tests/Integration/tests/version-substitution/expected/index.html b/tests/Integration/tests/version-substitution/expected/index.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <title>Versions - Example</title>
+
+</head>
+<body>
+<!-- content start -->
+    <div class="section" id="versions">
+            <h1>Versions</h1>
+            
+    <p>This documents version 0.10 (release 1.0).</p>
+
+    </div>
+<!-- content end -->
+</body>
+</html>
diff --git a/tests/Integration/tests/version-substitution/input/guides.xml b/tests/Integration/tests/version-substitution/input/guides.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<guides xmlns="https://www.phpdoc.org/guides">
+    <project title="Example" version="0.10" release="1.0"/>
+</guides>
diff --git a/tests/Integration/tests/version-substitution/input/index.rst b/tests/Integration/tests/version-substitution/input/index.rst
@@ -0,0 +1,5 @@
+========
+Versions
+========
+
+This documents version |version| (release |release|).
