Resolve RST anonymous heading refs against the current page first#1329
Closed
lacatoire wants to merge 1 commit into
Closed
Resolve RST anonymous heading refs against the current page first#1329lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
`Heading 1`_ on page2 was rendering `<a href="page1.html#heading-1">` whenever page1 happened to carry an identically named section: the project-wide anchor index silently overwrites `std:title` entries on duplicate keys, so the lookup returned whichever document registered last. Store link targets in a document-scoped index alongside the global one and let AnchorHyperlinkResolver consult the current page before falling back to the global match, so same-named sections on other pages no longer shadow the local one.
lacatoire
force-pushed
the
fix/internal-anchors-prefer-current-doc
branch
from
4834ef0 to
1c689f0
Compare
Member
|
Thanks for helping out, I decided to solve this in a different way, but I did add the missing tests to the test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RST anonymous references (
\`Heading 1\`_) resolved to a same-named heading on another page because the project-wide anchor index silently overwritesstd:titleentries on duplicate keys. Stores link targets in a document-scoped index alongside the global one;AnchorHyperlinkResolvernow consults the current page before falling back to the global match.Fixes phpDocumentor/phpDocumentor#3781