Validate campaign before setting status to submitted

Author: tatevikg1

src/Domain/Messaging/Service/Builder/MessageBuilder.php

@@ -42,6 +42,7 @@ public function build(MessageDtoInterface $createMessageDto, object $context = n
             $context->getExisting()->setContent($content);
             $context->getExisting()->setOptions($options);
             $context->getExisting()->setTemplate($template);
+
             return $context->getExisting();
         }
 

src/Domain/Messaging/Service/Manager/MessageManager.php

@@ -4,6 +4,7 @@
 
 namespace PhpList\Core\Domain\Messaging\Service\Manager;
 
+use InvalidArgumentException;
 use PhpList\Core\Domain\Identity\Model\Administrator;
 use PhpList\Core\Domain\Messaging\Model\Dto\MessageContext;
 use PhpList\Core\Domain\Messaging\Model\Dto\MessageDtoInterface;
@@ -61,6 +62,12 @@ public function updateMessage(
 
     public function updateStatus(Message $message, Message\MessageStatus $status): Message
     {
+        if ($status === Message\MessageStatus::Submitted && !$this->canBeSubmitted($message)) {
+            throw new InvalidArgumentException(
+                'Cannot set status to submitted: add at least one list and fill subject, from field, and message body.'
+            );
+        }
+
         $message->getMetadata()->setStatus($status);
 
         return $message;
@@ -76,4 +83,17 @@ public function getMessagesByOwner(Administrator $owner): array
     {
         return $this->messageRepository->getByOwnerId($owner->getId());
     }
+
+    private function canBeSubmitted(Message $message): bool
+    {
+        return $message->getListMessages()->count() > 0
+            && $this->isFilled($message->getContent()->getSubject())
+            && $this->isFilled($message->getOptions()->getFromField())
+            && $this->isFilled($message->getContent()->getText());
+    }
+
+    private function isFilled(?string $value): bool
+    {
+        return !empty(trim((string) $value));
+    }
 }

tests/Unit/Domain/Messaging/Service/Manager/MessageManagerTest.php

@@ -5,7 +5,9 @@
 namespace PhpList\Core\Tests\Unit\Domain\Messaging\Service\Manager;
 
 use DateTime;
+use InvalidArgumentException;
 use PhpList\Core\Domain\Identity\Model\Administrator;
+use PhpList\Core\Domain\Messaging\Model\ListMessage;
 use PhpList\Core\Domain\Messaging\Model\Dto\CreateMessageDto;
 use PhpList\Core\Domain\Messaging\Model\Dto\Message\MessageContentDto;
 use PhpList\Core\Domain\Messaging\Model\Dto\Message\MessageFormatDto;
@@ -22,6 +24,7 @@
 use PhpList\Core\Domain\Messaging\Repository\MessageRepository;
 use PhpList\Core\Domain\Messaging\Service\Builder\MessageBuilder;
 use PhpList\Core\Domain\Messaging\Service\Manager\MessageManager;
+use PhpList\Core\Domain\Subscription\Model\SubscriberList;
 use PHPUnit\Framework\TestCase;
 
 class MessageManagerTest extends TestCase
@@ -176,4 +179,63 @@ public function testUpdateMessageReturnsUpdatedMessage(): void
         $this->assertSame('Updated Subject', $message->getContent()->getSubject());
         $this->assertSame(Message\MessageStatus::Draft, $message->getMetadata()->getStatus());
     }
+
+    public function testUpdateStatusThrowsWhenSubmittedWithoutListMessage(): void
+    {
+        $messageRepository = $this->createMock(MessageRepository::class);
+        $messageBuilder = $this->createMock(MessageBuilder::class);
+        $manager = new MessageManager($messageRepository, $messageBuilder);
+
+        $message = new Message(
+            format: new MessageFormat(true, 'html'),
+            schedule: new MessageSchedule(
+                repeatInterval: 0,
+                repeatUntil: null,
+                requeueInterval: 0,
+                requeueUntil: null,
+                embargo: new DateTime('2025-04-17T09:00:00+00:00')
+            ),
+            metadata: new MessageMetadata(Message\MessageStatus::Draft),
+            content: new MessageContent('Subject', 'Body text', 'Short text', 'Footer'),
+            options: new MessageOptions('from@example.com', 'to@example.com', 'reply@example.com', 'all-users'),
+            owner: null
+        );
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Cannot set status to submitted');
+
+        $manager->updateStatus($message, Message\MessageStatus::Submitted);
+    }
+
+    public function testUpdateStatusSetsSubmittedWhenRequiredFieldsAndListArePresent(): void
+    {
+        $messageRepository = $this->createMock(MessageRepository::class);
+        $messageBuilder = $this->createMock(MessageBuilder::class);
+        $manager = new MessageManager($messageRepository, $messageBuilder);
+
+        $message = new Message(
+            format: new MessageFormat(true, 'html'),
+            schedule: new MessageSchedule(
+                repeatInterval: 0,
+                repeatUntil: null,
+                requeueInterval: 0,
+                requeueUntil: null,
+                embargo: new DateTime('2025-04-17T09:00:00+00:00')
+            ),
+            metadata: new MessageMetadata(Message\MessageStatus::Draft),
+            content: new MessageContent('Subject', 'Body text', 'Short text', 'Footer'),
+            options: new MessageOptions('from@example.com', 'to@example.com', 'reply@example.com', 'all-users'),
+            owner: null
+        );
+
+        $listMessage = new ListMessage();
+        $listMessage->setMessage($message);
+        $listMessage->setList($this->createMock(SubscriberList::class));
+        $message->getListMessages()->add($listMessage);
+
+        $updated = $manager->updateStatus($message, Message\MessageStatus::Submitted);
+
+        $this->assertSame($message, $updated);
+        $this->assertSame(Message\MessageStatus::Submitted, $message->getMetadata()->getStatus());
+    }
 }