Fix: not nullable fields

Author: tatevikg1

src/Domain/Messaging/Model/ListMessage.php

@@ -27,20 +27,22 @@ class ListMessage implements DomainModel, Identity, ModificationDate
 
     #[ORM\ManyToOne(targetEntity: Message::class, inversedBy: 'listMessages')]
     #[ORM\JoinColumn(name: 'messageid', referencedColumnName: 'id', nullable: false)]
-    private ?Message $message = null;
+    private Message $message;
 
     #[ORM\ManyToOne(targetEntity: SubscriberList::class, inversedBy: 'listMessages')]
     #[ORM\JoinColumn(name: 'listid', referencedColumnName: 'id', nullable: false)]
-    private ?SubscriberList $subscriberList = null;
+    private SubscriberList $subscriberList;
 
     #[ORM\Column(name: 'entered', type: 'datetime', nullable: true)]
     private ?DateTimeInterface $entered = null;
 
     #[ORM\Column(name: 'modified', type: 'datetime')]
     private ?DateTime $updatedAt = null;
 
-    public function __construct()
+    public function __construct(Message $message, SubscriberList $subscriberList)
     {
+        $this->message = $message;
+        $this->subscriberList = $subscriberList;
         $this->updatedAt = new DateTime();
         $this->entered = new DateTime();
     }
@@ -50,28 +52,16 @@ public function getId(): ?int
         return $this->id;
     }
 
-    public function getMessage(): ?Message
+    public function getMessage(): Message
     {
         return $this->message;
     }
 
-    public function setMessage(?Message $message): self
-    {
-        $this->message = $message;
-        return $this;
-    }
-
-    public function getList(): ?SubscriberList
+    public function getList(): SubscriberList
     {
         return $this->subscriberList;
     }
 
-    public function setList(?SubscriberList $subscriberList): self
-    {
-        $this->subscriberList = $subscriberList;
-        return $this;
-    }
-
     public function getEntered(): ?DateTimeInterface
     {
         return $this->entered;

src/Domain/Messaging/Service/Manager/ListMessageManager.php

@@ -37,10 +37,10 @@ public function __construct(
      */
     public function associateMessageWithList(Message $message, SubscriberList $subscriberList): ListMessage
     {
-        $listMessage = new ListMessage();
-        $listMessage->setMessage($message);
-        $listMessage->setList($subscriberList);
-
+        $listMessage = new ListMessage(
+            $message,
+            $subscriberList
+        );
         $this->entityManager->persist($listMessage);
 
         return $listMessage;

tests/Integration/Domain/Messaging/Repository/UserMessageBounceRepositoryTest.php

@@ -119,18 +119,18 @@ public function testGetListBounceTotalsReturnsAggregatedBouncesPerSubscriberForL
         self::assertSame(
             [
                 [
-                    'subscriberId' => $subscriber1->getId(),
+                    'subscriber_id' => $subscriber1->getId(),
                     'email' => 'one@example.com',
                     'confirmed' => true,
                     'blacklisted' => false,
-                    'totalBounces' => 2,
+                    'total_bounces' => 2,
                 ],
                 [
-                    'subscriberId' => $subscriber2->getId(),
+                    'subscriber_id' => $subscriber2->getId(),
                     'email' => 'two@example.com',
                     'confirmed' => false,
                     'blacklisted' => true,
-                    'totalBounces' => 1,
+                    'total_bounces' => 1,
                 ],
             ],
             $rows

tests/Unit/Domain/Messaging/Service/Manager/MessageManagerTest.php

@@ -229,9 +229,11 @@ public function testUpdateStatusSetsSubmittedWhenRequiredFieldsAndListArePresent
             owner: null
         );
 
-        $listMessage = new ListMessage();
-        $listMessage->setMessage($message);
-        $listMessage->setList($this->createMock(SubscriberList::class));
+        $listMessage = new ListMessage(
+            message: $message,
+            subscriberList: $this->createMock(SubscriberList::class)
+        );
+
         $message->getListMessages()->add($listMessage);
 
         $updated = $manager->updateStatus($message, Message\MessageStatus::Submitted);