update release CI

Author: michield

.github/workflows/build-release.yml

@@ -87,6 +87,9 @@ jobs:
           cp -fv tests/ci/behat.yml tests/behat.yml
           cp -fv tests/ci/config.php public_html/lists/config/config.php
           mkdir -p output/screenshots
+          chmod 777 output/screenshots
+          mkdir /tmp/screenshots
+          chmod 777 /tmp/screenshots
           mkdir -p build/mails
           ./bin/start-selenium > output/selenium.log 2>&1 &
           sleep 5
@@ -112,21 +115,31 @@ jobs:
           which sftp 
           which sshpass
           vendor/bin/behat -V
+          ls -l output
+          ls -l output/screenshots
 
-      - name: Run Behat Tests
+      - name: Run Behat Tests ## problem encountered https://github.com/forceedge01/behat-fail-aid/issues/76
         run: |
           cd $GITHUB_WORKSPACE/tests
-          ../vendor/bin/behat -n -fprogress -p chrome --strict --stop-on-failure --tags=@initialise
-          ../vendor/bin/behat -n -fprogress -p chrome --strict --stop-on-failure --tags="~@initialise && ~@wip"
+          ../vendor/bin/behat -n -p chrome --strict --stop-on-failure --tags=@initialise
+          ../vendor/bin/behat -n -p chrome --strict --stop-on-failure --tags="~@initialise && ~@wip"
 
-      - name: Upload the screenshots
+      - name: Upload the output
         if: always()
         uses: actions/upload-artifact@v4
         with:
           path: "output"
           name: "behat output"
           retention-days: 3
 
+      - name: Upload the screenshots
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          path: "/tmp/screenshots/"
+          name: "screenshots"
+          retention-days: 3
+
       - name: Clean Up
         run: |
           cd $GITHUB_WORKSPACE
@@ -259,7 +272,7 @@ jobs:
           cd $GITHUB_WORKSPACE
           cd ..
 
-          sshpass -e sftp -oBatchMode=no -b - ${{ secrets.SF_USERNAME }}@${{ secrets.SF_HOST }} << EOF
+          [[ $SSHPASS != "" ]] && sshpass -e sftp -oBatchMode=no -b - ${{ secrets.SF_USERNAME }}@${{ secrets.SF_HOST }} << EOF
             cd /home/frs/project/phplist/$RELEASE_FOLDER
             mkdir $RELEASE_VERSION
             cd $RELEASE_VERSION

tests/ci/behat.yml

@@ -56,16 +56,9 @@ default:
             wd_host: http://127.0.0.1:4444/wd/hub
     FailAid\Extension: 
       screenshot:
-        directory: ./output/screenshots/
+        directory: /tmp/screenshots/
         mode: default
         autoClean: false
-        size: 1444x1280
-    Bex\Behat\ScreenshotExtension:
-      active_image_drivers: [local]
-      image_drivers:
-        local:
-          screenshot_directory: output/screenshots
-          clear_screenshot_directory: true  
 
 chrome:
   extensions:

tests/features/bootstrap/FeatureContext.php

@@ -170,6 +170,12 @@ public function iAmAuthenticatedAsAdmin() {
         $this->fillField('login', $this->params['admin_username']);
         $this->fillField('password', $this->params['admin_password']);
         $this->pressButton('Continue');
+    	$this->getSession()->getDriver()->setTimeouts([
+            'script' => 3000000,
+            'implicit' => 3000000,
+            'page load' => 3000000 //https://web.archive.org/web/20160730151941/http://alex-panshin.me/blog/how-to-set-pageload-timeout-for-selenium-with-behat/
+
+        ]); 
     }
 
     /**
@@ -217,6 +223,14 @@ public function iFillInWithAValidPassword($arg1)
     {
         $this->fillField($arg1, $this->params['admin_password']);
     }
+    
+    /**
+     * @Given I refresh the page
+     */
+    public function iRefreshThePage()
+    {
+        $this->getSession()->getDriver()->reload();
+    }
 
     /**
      * @When /^I fill in "([^"]*)" with an email address$/

tests/features/getting-started/menu.feature

@@ -7,6 +7,7 @@ Feature: Navigate the app using the menu
 
   Scenario Outline: Use main menu navigation links
     Given I have logged in as an administrator
+    Given I follow "Dashboard"
     Then I should see "<Pagename>"
     Examples:
       | Pagename                  |
@@ -21,7 +22,6 @@ Feature: Navigate the app using the menu
      Then I should see "logout"
      Then I should see "Dashboard"
 
-
     Scenario Outline: Browse Subscribers menu
         Given I have logged in as an administrator
         Given I follow "Subscribers"
@@ -75,8 +75,10 @@ Feature: Navigate the app using the menu
          | Send the queue            |
          | Rebuild DB indexes        |
          | system                    |
+
      Scenario Outline: Browse Config menu
         Given I have logged in as an administrator
+        Given I follow "Dashboard"
         Given I follow "Config"
         Then I should see "<Innerpages>"
         Examples:

tests/features/managing-campaigns/newcampaign.feature

@@ -19,12 +19,15 @@ Feature: Create new campaign
         And I press "Save and continue editing"
         Then I should see "This is the Content of the Campaign"
         When I follow "Scheduling"
+        And I refresh the page
         Then I should see "Embargoed Until"
         When I follow "Lists"
+        And I refresh the page
         Then I should see "Please select the lists you want to send your campaign to"
         And I should see "All Lists"
         When I check "targetlist[all]"
         And I press "Save and continue editing"
+        And I refresh the page
         Then I should see "selected"
         When I follow "Finish"
         And I press "send"