Enhance SubscribePagePublicNormalizer to resolve attribute IDs using SubscriberAttributeDefinitionRepository

Author: tatevikg1

src/Subscription/Serializer/SubscribePagePublicNormalizer.php

@@ -7,6 +7,7 @@
 use OpenApi\Attributes as OA;
 use PhpList\Core\Domain\Subscription\Model\SubscribePage;
 use PhpList\Core\Domain\Subscription\Model\SubscribePageData;
+use PhpList\Core\Domain\Subscription\Repository\SubscriberAttributeDefinitionRepository;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 
 #[OA\Schema(
@@ -28,6 +29,11 @@
 )]
 class SubscribePagePublicNormalizer implements NormalizerInterface
 {
+    public function __construct(
+        private readonly SubscriberAttributeDefinitionRepository $attributeDefinitionRepository,
+    ) {
+    }
+
     /**
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
@@ -43,14 +49,39 @@ public function normalize($object, string $format = null, array $context = []):
             'data' => array_reduce(
                 $object->getData(),
                 function (array $carry, SubscribePageData $data) {
-                    $carry[$data->getName()] = $data->getData();
+                    $value = $data->getData();
+                    if ($data->getName() === 'attributes') {
+                        $ids = array_filter(explode('+',  $data->getData()));
+                        $value = $this->getAttributeDefinitions($ids);
+                    }
+                    $carry[$data->getName()] = $value;
+
                     return $carry;
                 },
                 []
             ),
         ];
     }
 
+    private function getAttributeDefinitions(array $ids): array
+    {
+        $attributeDefinitions = $this->attributeDefinitionRepository->getByIds($ids);
+        $result = [];
+        foreach ($attributeDefinitions as $attributeDefinition) {
+            $result[] = [
+                'id' => $attributeDefinition->getId(),
+                'name' => $attributeDefinition->getName(),
+                'type' => $attributeDefinition->getType()->value,
+                'required' => $attributeDefinition->isRequired(),
+                'default_value' => $attributeDefinition->getDefaultValue(),
+                'list_order' => $attributeDefinition->getListOrder(),
+                'options' => $attributeDefinition->getOptions(),
+            ];
+        }
+
+        return $result;
+    }
+
     /**
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */

tests/Unit/Subscription/Serializer/SubscribePagePublicNormalizerTest.php

@@ -6,6 +6,7 @@
 
 use PhpList\Core\Domain\Identity\Model\Administrator;
 use PhpList\Core\Domain\Subscription\Model\SubscribePage;
+use PhpList\Core\Domain\Subscription\Repository\SubscriberAttributeDefinitionRepository;
 use PhpList\RestBundle\Subscription\Serializer\SubscribePagePublicNormalizer;
 use PHPUnit\Framework\TestCase;
 use stdClass;
@@ -14,7 +15,9 @@ class SubscribePagePublicNormalizerTest extends TestCase
 {
     public function testSupportsNormalization(): void
     {
-        $normalizer = new SubscribePagePublicNormalizer();
+        $normalizer = new SubscribePagePublicNormalizer(
+            $this->createMock(SubscriberAttributeDefinitionRepository::class)
+        );
 
         $page = $this->createMock(SubscribePage::class);
 
@@ -32,7 +35,9 @@ public function testNormalizeReturnsExpectedArray(): void
         $page->method('isActive')->willReturn(true);
         $page->method('getOwner')->willReturn($owner);
 
-        $normalizer = new SubscribePagePublicNormalizer();
+        $normalizer = new SubscribePagePublicNormalizer(
+            $this->createMock(SubscriberAttributeDefinitionRepository::class)
+        );
 
         $expected = [
             'id' => 42,
@@ -45,7 +50,9 @@ public function testNormalizeReturnsExpectedArray(): void
 
     public function testNormalizeWithInvalidObjectReturnsEmptyArray(): void
     {
-        $normalizer = new SubscribePagePublicNormalizer();
+        $normalizer = new SubscribePagePublicNormalizer(
+            $this->createMock(SubscriberAttributeDefinitionRepository::class)
+        );
         $this->assertSame([], $normalizer->normalize(new stdClass()));
     }
 }