Do not check privileges for dashboard analytics

Author: tatevikg1

src/Statistics/Controller/AnalyticsController.php

@@ -495,18 +495,15 @@ public function getTopLocalParts(Request $request): JsonResponse
                 )
             ),
             new OA\Response(
-                response: 403,
-                description: 'Unauthorized',
+                response: 401,
+                description: 'Not authenticated',
                 content: new OA\JsonContent(ref: '#/components/schemas/UnauthorizedResponse')
             )
         ]
     )]
     public function getDashboardStatistics(Request $request): JsonResponse
     {
-        $authUser = $this->requireAuthentication($request);
-        if (!$authUser->getPrivileges()->has(PrivilegeFlag::Statistics)) {
-            throw $this->createAccessDeniedException('You are not allowed to access statistics.');
-        }
+        $this->requireAuthentication($request);
 
         $response = [
             'summary_statistics' => $this->analyticsService->getSummaryStatistics(),

tests/Unit/Statistics/Controller/AnalyticsControllerTest.php

@@ -40,13 +40,13 @@ protected function setUp(): void
         $viewOpensStatisticsNormalizer = new ViewOpensStatisticsNormalizer();
         $topDomainsNormalizer = new TopDomainsNormalizer();
         $this->controller = new DummyAnalyticsController(
-            $this->authentication,
-            $validator,
-            $this->analyticsService,
-            $campaignStatisticsNormalizer,
-            $viewOpensStatisticsNormalizer,
-            $topDomainsNormalizer,
-            new TopLocalPartsNormalizer()
+            authentication: $this->authentication,
+            validator: $validator,
+            analyticsService: $this->analyticsService,
+            campaignStatsNormalizer: $campaignStatisticsNormalizer,
+            viewOpensStatsNormalizer: $viewOpensStatisticsNormalizer,
+            topDomainsNormalizer: $topDomainsNormalizer,
+            topLocalPartsNormalizer: new TopLocalPartsNormalizer()
         );
 
         $this->privileges = $this->createMock(Privileges::class);
@@ -443,7 +443,7 @@ public function testGetTopLocalPartsReturnsJsonResponse(): void
         ], json_decode($response->getContent(), true));
     }
 
-    public function testGetDashboardStatisticsWithoutStatisticsPrivilegeThrowsException(): void
+    public function testGetDashboardStatisticsWithoutStatisticsPrivilegeDoesNotThrowException(): void
     {
         $request = new Request();
 
@@ -454,14 +454,11 @@ public function testGetDashboardStatisticsWithoutStatisticsPrivilegeThrowsExcept
             ->willReturn($this->administrator);
 
         $this->privileges
-            ->expects(self::once())
+            ->expects(self::never())
             ->method('has')
             ->with(PrivilegeFlag::Statistics)
             ->willReturn(false);
 
-        $this->expectException(AccessDeniedException::class);
-        $this->expectExceptionMessage('You are not allowed to access statistics.');
-
         $this->controller->getDashboardStatistics($request);
     }
 
@@ -476,7 +473,7 @@ public function testGetDashboardStatisticsReturnsJsonResponse(): void
             ->willReturn($this->administrator);
 
         $this->privileges
-            ->expects(self::once())
+            ->expects(self::never())
             ->method('has')
             ->with(PrivilegeFlag::Statistics)
             ->willReturn(true);