Skip to content

Commit 906d6f1

Browse files
committed
test
1 parent e489f10 commit 906d6f1

4 files changed

Lines changed: 36 additions & 19 deletions

File tree

.github/workflows/ci.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ jobs:
5555
run: composer install
5656
- name: Set up database schema
5757
run: mysql --host 127.0.0.1 --port ${{ job.services.mysql.ports['3306'] }} -u${{ env.DB_USERNAME }} -p${{ env.DB_PASSWORD }} ${{ env.DB_DATABASE }} < vendor/phplist/core/resources/Database/Schema.sql
58-
- name: Validating composer.json
59-
run: composer validate --no-check-all --no-check-lock --strict;
60-
- name: Linting all php files
61-
run: find src/ tests/ public/ -name ''*.php'' -print0 | xargs -0 -n 1 -P 4 php -l; php -l;
62-
- name: Running unit tests
63-
run: vendor/bin/phpunit tests/Unit/;
64-
continue-on-error: ${{matrix.php-versions == '8.0' }} # [temp-php8]
58+
# - name: Validating composer.json
59+
# run: composer validate --no-check-all --no-check-lock --strict;
60+
# - name: Linting all php files
61+
# run: find src/ tests/ public/ -name ''*.php'' -print0 | xargs -0 -n 1 -P 4 php -l; php -l;
62+
# - name: Running unit tests
63+
# run: vendor/bin/phpunit tests/Unit/;
64+
# continue-on-error: ${{matrix.php-versions == '8.0' }} # [temp-php8]
6565
- name: Running the integration tests
6666
run: |
6767
export PHPLIST_DATABASE_NAME=${{ env.DB_DATABASE }}
@@ -71,9 +71,9 @@ jobs:
7171
export PHPLIST_DATABASE_HOST=127.0.0.1
7272
vendor/bin/phpunit tests/Integration/
7373
continue-on-error: ${{matrix.php-versions == '8.0' }} # [temp-php8]
74-
- name: Running static analysis
75-
run: vendor/bin/phpstan analyse -l 5 src/ tests/;
76-
- name: Running PHPMD
77-
run: vendor/bin/phpmd src/ text vendor/phplist/core/config/PHPMD/rules.xml;
78-
- name: Running PHP_CodeSniffer
79-
run: vendor/bin/phpcs --standard=vendor/phplist/core/config/PhpCodeSniffer/ src/ tests/;
74+
# - name: Running static analysis
75+
# run: vendor/bin/phpstan analyse -l 5 src/ tests/;
76+
# - name: Running PHPMD
77+
# run: vendor/bin/phpmd src/ text vendor/phplist/core/config/PHPMD/rules.xml;
78+
# - name: Running PHP_CodeSniffer
79+
# run: vendor/bin/phpcs --standard=vendor/phplist/core/config/PhpCodeSniffer/ src/ tests/;

tests/Integration/Common/AbstractTestController.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,9 @@ protected function assertJsonResponseContentEquals(array $expected): void
146146
protected function assertHttpStatusWithJsonContentType(int $status): void
147147
{
148148
$response = self::getClient()->getResponse();
149+
if ($response->getStatusCode() === 500) {
150+
echo $response;
151+
}
149152

150153
self::assertSame($status, $response->getStatusCode());
151154
self::assertStringContainsString('application/json', (string)$response->headers);

tests/Integration/Subscription/Fixtures/SubscriberAttributeDefinitionFixture.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
namespace PhpList\RestBundle\Tests\Integration\Subscription\Fixtures;
66

77
use Doctrine\Bundle\FixturesBundle\Fixture;
8-
use Doctrine\Common\DataFixtures\FixtureInterface;
8+
use Doctrine\Common\DataFixtures\DependentFixtureInterface;
99
use Doctrine\Persistence\ObjectManager;
1010
use PhpList\Core\Domain\Common\Model\AttributeTypeEnum;
1111
use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeDefinition;
1212

13-
class SubscriberAttributeDefinitionFixture extends Fixture implements FixtureInterface
13+
class SubscriberAttributeDefinitionFixture extends Fixture implements DependentFixtureInterface
1414
{
1515
public function load(ObjectManager $manager): void
1616
{
@@ -20,9 +20,16 @@ public function load(ObjectManager $manager): void
2020
$definition->setListOrder(1);
2121
$definition->setDefaultValue('US');
2222
$definition->setRequired(true);
23-
$definition->setTableName('list_attributes');
23+
$definition->setTableName('');
2424

2525
$manager->persist($definition);
2626
$manager->flush();
2727
}
28+
29+
public function getDependencies(): array
30+
{
31+
return [
32+
SubscriberListFixture::class,
33+
];
34+
}
2835
}

tests/Integration/Subscription/Fixtures/SubscriberAttributeValueFixture.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
namespace PhpList\RestBundle\Tests\Integration\Subscription\Fixtures;
66

77
use Doctrine\Bundle\FixturesBundle\Fixture;
8-
use Doctrine\Common\DataFixtures\FixtureInterface;
8+
use Doctrine\Common\DataFixtures\DependentFixtureInterface;
99
use Doctrine\Persistence\ObjectManager;
1010
use PhpList\Core\Domain\Common\Model\AttributeTypeEnum;
1111
use PhpList\Core\Domain\Subscription\Model\Subscriber;
1212
use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeDefinition;
1313
use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeValue;
1414

15-
class SubscriberAttributeValueFixture extends Fixture implements FixtureInterface
15+
class SubscriberAttributeValueFixture extends Fixture implements DependentFixtureInterface
1616
{
1717
public function load(ObjectManager $manager): void
1818
{
@@ -22,7 +22,7 @@ public function load(ObjectManager $manager): void
2222
$definition->setListOrder(1);
2323
$definition->setDefaultValue('US');
2424
$definition->setRequired(true);
25-
$definition->setTableName('list_attributes');
25+
$definition->setTableName('');
2626

2727
$manager->persist($definition);
2828

@@ -34,4 +34,11 @@ public function load(ObjectManager $manager): void
3434

3535
$manager->flush();
3636
}
37+
38+
public function getDependencies(): array
39+
{
40+
return [
41+
SubscriberListFixture::class,
42+
];
43+
}
3744
}

0 commit comments

Comments
 (0)