Remove api_base_url from controller render methods and add it as a global variable in twig configuration

Author: tatevikg1

config/packages/twig.yaml

@@ -3,3 +3,5 @@ twig:
     strict_variables: '%kernel.debug%'
     default_path: '%kernel.application_dir%/templates'
     auto_reload: true
+    globals:
+        api_base_url: '%app.api_base_url%'

src/Controller/AnalyticsController.php

@@ -18,7 +18,6 @@ public function index(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Analytics',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 }

src/Controller/BouncesController.php

@@ -24,7 +24,6 @@ public function index(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Bounces',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
             'bounce_actions' => $bounceActions,
         ]);
     }

src/Controller/CampaignsController.php

@@ -18,7 +18,6 @@ public function index(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Campaigns',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 
@@ -28,7 +27,6 @@ public function create(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Create Campaign',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 
@@ -38,7 +36,6 @@ public function edit(Request $request, int $campaignId): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => sprintf('Edit Campaign #%d', $campaignId),
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 }

src/Controller/DashboardController.php

@@ -33,7 +33,6 @@ public function index(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Dashboard',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
             'dashboard_stats' => $dashboardStats,
             'dashboard_error' => $dashboardError,
         ]);

src/Controller/ListsController.php

@@ -27,7 +27,6 @@ public function index(Request $request): JsonResponse|Response
             return $this->render('@PhpListFrontend/spa.html.twig', [
                 'page' => 'Lists',
                 'api_token' => $request->getSession()->get('auth_token'),
-                'api_base_url' => $this->getParameter('app.api_base_url'),
             ]);
         }
         $initialData = $this->listClient->getLists();
@@ -41,7 +40,6 @@ public function view(Request $request, int $listId): JsonResponse|Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'List Subscribers',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 }

src/Controller/PublicPagesController.php

@@ -18,7 +18,6 @@ public function index(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Subscribe Pages',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 
@@ -28,7 +27,6 @@ public function create(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Create Subscribe Page',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 
@@ -38,7 +36,6 @@ public function edit(Request $request, int $pageId): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => sprintf('Edit Subscribe Page #%d', $pageId),
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 }

src/Controller/SettingsController.php

@@ -18,7 +18,6 @@ public function index(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Settings',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 }

src/Controller/SubscribersController.php

@@ -38,7 +38,6 @@ public function index(Request $request): JsonResponse|Response
             return $this->render('@PhpListFrontend/spa.html.twig', [
                 'page' => 'Subscribers',
                 'api_token' => $request->getSession()->get('auth_token'),
-                'api_base_url' => $this->getParameter('app.api_base_url'),
             ]);
         }
 

src/Controller/TemplatesController.php

@@ -18,7 +18,6 @@ public function index(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Templates',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 
@@ -28,7 +27,6 @@ public function create(Request $request): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => 'Create Template',
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 
@@ -38,7 +36,6 @@ public function edit(Request $request, int $templateId): Response
         return $this->render('@PhpListFrontend/spa.html.twig', [
             'page' => sprintf('Edit Template #%d', $templateId),
             'api_token' => $request->getSession()->get('auth_token'),
-            'api_base_url' => $this->getParameter('app.api_base_url'),
         ]);
     }
 }