Update coding standard (#11)

Author: dantleech

.github/workflows/ci.yml

@@ -43,7 +43,7 @@ jobs:
 
             -
                 name: "Run friendsofphp/php-cs-fixer"
-                run: "vendor/bin/php-cs-fixer fix --dry-run --diff --verbose"
+                run: "vendor/bin/php-cs-fixer fix --dry-run --diff --verbose --allow-risky=yes"
     phpstan:
         name: "PHPStan (${{ matrix.php-version }})"
 

.php_cs.dist

@@ -4,7 +4,7 @@ $finder = PhpCsFixer\Finder::create()
     ->in('lib')
     ->in('tests')
     ->exclude([
-        'tests/Workspace'
+        'Workspace',
     ])
 ;
 
@@ -13,6 +13,11 @@ return PhpCsFixer\Config::create()
         '@PSR2' => true,
         'no_unused_imports' => true,
         'array_syntax' => ['syntax' => 'short'],
+        'void_return' => true,
+        'ordered_class_elements' => true,
+        'single_quote' => true,
+        'heredoc_indentation' => true,
+        'global_namespace_import' => true,
     ])
     ->setFinder($finder)
 ;

lib/CompletionExtension.php

@@ -35,7 +35,7 @@ class CompletionExtension implements Extension
     /**
      * {@inheritDoc}
      */
-    public function configure(Resolver $schema)
+    public function configure(Resolver $schema): void
     {
         $schema->setDefaults([
             self::PARAM_DEDUPE => true,
@@ -52,7 +52,7 @@ public function configure(Resolver $schema)
     /**
      * {@inheritDoc}
      */
-    public function load(ContainerBuilder $container)
+    public function load(ContainerBuilder $container): void
     {
         $this->registerCompletion($container);
     }

tests/Unit/CompletionExtensionTest.php

@@ -46,7 +46,7 @@ public function setUp(): void
         $this->formatter1 = $this->prophesize(Formatter::class);
     }
 
-    public function testCreatesChainedCompletor()
+    public function testCreatesChainedCompletor(): void
     {
         $document = TextDocumentBuilder::create(self::EXAMPLE_SOURCE)->build();
         $this->completor1->complete(
@@ -67,7 +67,7 @@ public function testCreatesChainedCompletor()
         $this->assertEquals(self::EXAMPLE_SUGGESTION, $results[0]->name());
     }
 
-    public function testCreatesFormatterFromEitherSingleFormatterOrArray()
+    public function testCreatesFormatterFromEitherSingleFormatterOrArray(): void
     {
         $object = new stdClass();
         $this->formatter1->canFormat($object)->shouldBeCalledTimes(3)->willReturn(false);
@@ -77,7 +77,7 @@ public function testCreatesFormatterFromEitherSingleFormatterOrArray()
         $this->assertEquals(false, $canFormat);
     }
 
-    public function testCreatesSignatureHelper()
+    public function testCreatesSignatureHelper(): void
     {
         $document = TextDocumentBuilder::create(self::EXAMPLE_SOURCE)->build();
         $this->signatureHelper1->signatureHelp(