Skip to content

Fixing some small Honeybager alerts #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvanjohnson merged 7 commits into from
May 7, 2026
+682 −5
Merged

Fixing some small Honeybager alerts #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c5acd52
Fixing some small Honeybager alerts
ericvanjohnson Mar 31, 2026
3fb5ade
feat: add withTestLogo factory state to avoid S3 dependency in tests
ericvanjohnson Apr 2, 2026
f158d74
fix: remove S3 dependency, redundant RefreshDatabase, and redundant p…
ericvanjohnson Apr 2, 2026
e1dd87d
test: add comprehensive tests for Sponsor logoUrl accessor
ericvanjohnson Apr 2, 2026
d313b82
test: add model relationship tests for Conference, Sponsor, and User
ericvanjohnson Apr 2, 2026
c1e70a7
Merge branch 'main' of github.com:phparch/phptek-2026
ericvanjohnson May 6, 2026
cc0156e
Countdown banner
ericvanjohnson May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions database/factories/SponsorFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,26 @@ public function definition(): array
];
}

/**
* Create a sponsor without a website.
*/
public function withoutWebsite(): static
{
return $this->state(fn (array $attributes) => [
'website' => null,
]);
}

/**
* Create a sponsor with an HTTP logo URL (avoids S3 dependency in tests).
*/
public function withTestLogo(): static
{
return $this->state(fn (array $attributes) => [
'logo' => 'https://example.com/logos/test-logo.png',
]);
}

/**
* Create PHP Architect sponsor with specific data.
*/
Expand Down
18 changes: 18 additions & 0 deletions database/migrations/2026_03_31_004613_make_sponsor_website_nullable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

return new class extends Migration
{
/**
* Run the migrations.
*/
public function up(): void
{
Schema::table('sponsors', function (Blueprint $table) {
$table->string('website')->nullable()->change();
});
Comment on lines +14 to +16
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration uses ->change() to alter an existing column, but doctrine/dbal is not installed (not present in composer.json). On common setups (including SQLite), this can cause migrations to fail at runtime. Consider adding the required dependency or rewriting the migration to avoid change() (e.g., a DB-specific alter statement or table rebuild strategy).

Suggested change
Schema::table('sponsors', function (Blueprint $table) {
$table->string('website')->nullable()->change();
});
$connection = Schema::getConnection();
$driver = $connection->getDriverName();
if ($driver === 'mysql') {
$connection->statement('ALTER TABLE sponsors MODIFY website VARCHAR(255) NULL');
} elseif ($driver === 'pgsql') {
$connection->statement('ALTER TABLE sponsors ALTER COLUMN website DROP NOT NULL');
} elseif ($driver === 'sqlsrv') {
$connection->statement('ALTER TABLE sponsors ALTER COLUMN website NVARCHAR(255) NULL');
}

Copilot uses AI. Check for mistakes.
}
Comment thread
ericvanjohnson marked this conversation as resolved.
};
Loading
Loading