Some files needed for the mobile app by ericvanjohnson · Pull Request #57 · phparch/phptek-2026

ericvanjohnson · 2026-05-10T18:13:53Z

Summary by CodeRabbit

New Features
- Added support for iOS and Android app linking, enabling seamless deep linking between the web platform and mobile applications.

claude

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

coderabbitai · 2026-05-10T18:14:05Z

Walkthrough

Two configuration files are added to enable app linking. The iOS Universal Links file (apple-app-site-association) configures app ID 4P2UTS263F.com.phptek.mobile with URL matching rules, while the Android App Links file (assetlinks.json) establishes trust for package io.phptek.mobile with certificate fingerprints.

Changes

Mobile App Linking Configuration

Layer / File(s)	Summary
iOS Universal Links Configuration `public/.well-known/apple-app-site-association`	Defines `applinks` rules for app ID `4P2UTS263F.com.phptek.mobile` with URL patterns that exclude `/partners/` but route `/partners/*` to the iOS Connect tab.
Android App Links Configuration `public/.well-known/assetlinks.json`	Declares app link association for `io.phptek.mobile` package with two SHA-256 certificate fingerprints and `delegate_permission/common.handle_all_urls` permission.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Two little files, so small and neat,
Links for iOS and Android, now complete!
Apple and Google, shaking hands with glee,
Deep linking magic, for all apps to see! 📱✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Some files needed for the mobile app' is vague and generic, failing to specify which files or what configuration changes are being added.	Use a more descriptive title such as 'Add Apple App Site Association and Android App Links configuration' to clearly indicate the specific files and their purpose.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

public/.well-known/apple-app-site-association (1)
1-20: Ensure proper Content-Type header when serving this file.

The apple-app-site-association file must be served with Content-Type: application/json (or application/pkcs7-mime for signed files) and must be accessible via HTTPS. Since this is in a public/.well-known/ directory, verify your web server configuration serves it correctly without requiring a file extension.

Test the configuration after deployment using Apple's validation tools and by testing actual deep links on a physical iOS device. The Apple App Site Association (AASA) file validator can help verify the configuration is accessible and valid.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@public/.well-known/apple-app-site-association` around lines 1 - 20, Serve the
apple-app-site-association JSON blob under
.well-known/apple-app-site-association with the correct Content-Type by
configuring the server to return Content-Type: application/json (or
application/pkcs7-mime for signed files) for requests to the
.well-known/apple-app-site-association path; ensure the file is served without
an extension, over HTTPS, and that any static-file middleware or CDN does not
rewrite/require extensions or block this path so the JSON (the applinks ->
details -> components object in the provided file) is reachable by Apple
validation tools and real iOS devices.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@public/.well-known/apple-app-site-association`:
- Around line 1-20: Serve the apple-app-site-association JSON blob under
.well-known/apple-app-site-association with the correct Content-Type by
configuring the server to return Content-Type: application/json (or
application/pkcs7-mime for signed files) for requests to the
.well-known/apple-app-site-association path; ensure the file is served without
an extension, over HTTPS, and that any static-file middleware or CDN does not
rewrite/require extensions or block this path so the JSON (the applinks ->
details -> components object in the provided file) is reachable by Apple
validation tools and real iOS devices.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d43004a7-e1ab-4cd8-9776-228a958cd93d

📥 Commits

Reviewing files that changed from the base of the PR and between 0546139 and 3236398.

📒 Files selected for processing (2)

public/.well-known/apple-app-site-association
public/.well-known/assetlinks.json

Copilot

Pull request overview

Adds the platform association files required for mobile deep linking / app linking so the iOS and Android apps can claim URL handling for the site.

Changes:

Add Android Digital Asset Links configuration (assetlinks.json) for io.phptek.mobile.
Add iOS Universal Links association file (apple-app-site-association) with path-based include/exclude rules.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
public/.well-known/assetlinks.json	Declares Android app link relationship and signing certificate fingerprints.
public/.well-known/apple-app-site-association	Declares iOS Universal Links appID and path components for deep-link behavior.

+          {
+            "/": "/partners/",
+            "exclude": true,
+            "comment": "Partners index page stays on the web"
+          },


+{
+  "applinks": {
+    "details": [


svpernova09

The file type comment might be relevant? yolo

Some files needed for the mobile app

3236398

claude Bot reviewed May 10, 2026

View reviewed changes

ericvanjohnson temporarily deployed to Testing May 10, 2026 18:13 — with GitHub Actions Inactive

ericvanjohnson requested a review from Copilot May 10, 2026 18:14

ericvanjohnson requested review from fwallen, johncongdon and svpernova09 May 10, 2026 18:14

Copilot started reviewing on behalf of ericvanjohnson May 10, 2026 18:14 View session

coderabbitai Bot reviewed May 10, 2026

View reviewed changes

Copilot AI reviewed May 10, 2026

View reviewed changes

coderabbitai Bot approved these changes May 10, 2026

View reviewed changes

svpernova09 approved these changes May 11, 2026

View reviewed changes

ericvanjohnson merged commit 775ae0f into phparch:main May 11, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some files needed for the mobile app#57

Some files needed for the mobile app#57
ericvanjohnson merged 1 commit into
phparch:mainfrom
ericvanjohnson:main

ericvanjohnson commented May 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

claude Bot left a comment

Uh oh!

coderabbitai Bot commented May 10, 2026 •

edited

Loading

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

svpernova09 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ericvanjohnson commented May 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

coderabbitai Bot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

svpernova09 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ericvanjohnson commented May 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 10, 2026 •

edited

Loading