Fix tests

Author: iMattPro

tests/ad/prepare_ad_code_test.php

@@ -30,7 +30,7 @@ public function test_returns_empty_string_unchanged()
 		self::assertSame('', $this->get_manager()->prepare_ad_code('', true));
 	}
 
-	public function executable_script_type_data()
+	public static function executable_script_type_data()
 	{
 		return [
 			'normal script' => [
@@ -86,7 +86,7 @@ public function test_does_not_double_wrap_already_tagged_script()
 		self::assertSame(1, substr_count($result, 'data-consent-category='));
 	}
 
-	public function google_consent_aware_script_data()
+	public static function google_consent_aware_script_data()
 	{
 		return [
 			'adsense loader' => [

tests/event/setup_ads_consentmanager_test.php

@@ -25,11 +25,11 @@ public function test_setup_ads_defers_ad_markup_when_consentmanager_is_enabled()
 
 		$this->manager = $this->getMockBuilder('\phpbb\ads\ad\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('load_memberships', 'get_ads'))
+			->onlyMethods(array('load_memberships', 'get_ads'))
 			->getMock();
 		$this->location_manager = $this->getMockBuilder('\phpbb\ads\location\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('get_all_location_ids'))
+			->onlyMethods(array('get_all_location_ids'))
 			->getMock();
 
 		$this->location_manager->expects(self::once())
@@ -87,11 +87,11 @@ public function test_setup_ads_adds_consent_category_to_text_plain_scripts()
 
 		$this->manager = $this->getMockBuilder('\phpbb\ads\ad\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('load_memberships', 'get_ads'))
+			->onlyMethods(array('load_memberships', 'get_ads'))
 			->getMock();
 		$this->location_manager = $this->getMockBuilder('\phpbb\ads\location\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('get_all_location_ids'))
+			->onlyMethods(array('get_all_location_ids'))
 			->getMock();
 
 		$this->location_manager->expects(self::once())
@@ -146,11 +146,11 @@ public function test_setup_ads_does_not_defer_when_marketing_category_is_disable
 
 		$this->manager = $this->getMockBuilder('\phpbb\ads\ad\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('load_memberships', 'get_ads'))
+			->onlyMethods(array('load_memberships', 'get_ads'))
 			->getMock();
 		$this->location_manager = $this->getMockBuilder('\phpbb\ads\location\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('get_all_location_ids'))
+			->onlyMethods(array('get_all_location_ids'))
 			->getMock();
 
 		$this->location_manager->expects(self::once())
@@ -201,11 +201,11 @@ public function test_setup_ads_does_not_defer_when_ad_consent_is_disabled()
 
 		$this->manager = $this->getMockBuilder('\phpbb\ads\ad\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('load_memberships', 'get_ads'))
+			->onlyMethods(array('load_memberships', 'get_ads'))
 			->getMock();
 		$this->location_manager = $this->getMockBuilder('\phpbb\ads\location\manager')
 			->disableOriginalConstructor()
-			->setMethods(array('get_all_location_ids'))
+			->onlyMethods(array('get_all_location_ids'))
 			->getMock();
 
 		$this->location_manager->expects(self::once())