Refactor new lang file name and add functional test

iMattPro · iMattPro · commit ae66b7f64115 · 2025-09-08T15:51:34.000-07:00
diff --git a/event/main_listener.php b/event/main_listener.php
@@ -379,7 +379,7 @@ public function append_agreement()
 			return;
 		}
 
-		$this->language->add_lang('info_ucp_mediaembed', 'phpbb/mediaembed');
+		$this->language->add_lang('ucp', 'phpbb/mediaembed');
 
 		$this->template->append_var('AGREEMENT_TEXT', $this->language->lang('MEDIA_EMBED_PRIVACY_POLICY', $this->config['sitename']));
 	}
diff --git a/language/en/ucp.php b/language/en/ucp.php
diff --git a/tests/functional/media_embed_test.php b/tests/functional/media_embed_test.php
@@ -172,6 +172,14 @@ public function test_acp_modules()
 		$this->assert_checkbox_is_checked($crawler, 'youtube');
 	}
 
+	public function test_ucp_agreement()
+	{
+		$this->add_lang_ext('phpbb/mediaembed', 'ucp');
+
+		$crawler = self::request('GET', 'ucp.php?mode=privacy');
+		$this->assertStringContainsString($this->lang('MEDIA_EMBED_PRIVACY_POLICY', 'yourdomain.com'), $crawler->filter('.agreement')->html());
+	}
+
 	/**
 	 * Override original function to search by checkbox value instead of name
 	 *

Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,7 @@ public function append_agreement()`
`379`	`379`	`return;`
`380`	`380`	`}`
`381`	`381`
`382`		`- $this->language->add_lang('info_ucp_mediaembed', 'phpbb/mediaembed');`
	`382`	`+ $this->language->add_lang('ucp', 'phpbb/mediaembed');`
`383`	`383`
`384`	`384`	`$this->template->append_var('AGREEMENT_TEXT', $this->language->lang('MEDIA_EMBED_PRIVACY_POLICY', $this->config['sitename']));`
`385`	`385`	`}`
Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,14 @@ public function test_acp_modules()`
`172`	`172`	`$this->assert_checkbox_is_checked($crawler, 'youtube');`
`173`	`173`	`}`
`174`	`174`
	`175`	`+ public function test_ucp_agreement()`
	`176`	`+ {`
	`177`	`+ $this->add_lang_ext('phpbb/mediaembed', 'ucp');`
	`178`	`+`
	`179`	`+ $crawler = self::request('GET', 'ucp.php?mode=privacy');`
	`180`	`+ $this->assertStringContainsString($this->lang('MEDIA_EMBED_PRIVACY_POLICY', 'yourdomain.com'), $crawler->filter('.agreement')->html());`
	`181`	`+ }`
	`182`	`+`
`175`	`183`	`/**`
`176`	`184`	`* Override original function to search by checkbox value instead of name`
`177`	`185`	`*`