Skip to content

Commit 39360f9

Browse files
committed
Revert naming to old ga as deprecated
1 parent 7c49815 commit 39360f9

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

config/skeletons.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,10 @@ services:
171171
tags:
172172
- { name: phpbb.skeleton.ext.skeleton }
173173

174-
phpbb.skeleton.ext.skeleton.githubactions_deprecated:
174+
phpbb.skeleton.ext.skeleton.githubactions_custom:
175175
class: phpbb\skeleton\skeleton
176176
arguments:
177-
- 'githubactions_deprecated'
177+
- 'githubactions_custom'
178178
- false
179179
- []
180180
- ['.github/workflows/tests.yml']

console/create.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ protected function get_component_data()
160160
foreach ($components as $component => $details)
161161
{
162162
// Skip early as it's handled elsewhere
163-
if ($component === 'githubactions_deprecated')
163+
if ($component === 'githubactions_custom')
164164
{
165165
continue;
166166
}
@@ -254,14 +254,14 @@ private function handle_github_actions(): void
254254
$index = array_search($choice, $choices, true);
255255

256256
$this->data['components']['githubactions'] = false;
257-
$this->data['components']['githubactions_deprecated'] = false;
257+
$this->data['components']['githubactions_custom'] = false;
258258

259259
// Initialize both flags to false
260260
$this->data['components'] = array_merge(
261261
$this->data['components'],
262262
[
263263
'githubactions' => false,
264-
'githubactions_deprecated' => false
264+
'githubactions_custom' => false
265265
]
266266
);
267267

@@ -271,7 +271,7 @@ private function handle_github_actions(): void
271271
}
272272
else if ($index === 2)
273273
{
274-
$this->data['components']['githubactions_deprecated'] = true;
274+
$this->data['components']['githubactions_custom'] = true;
275275
}
276276
}
277277
}

language/en/common.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@
128128
],
129129
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_UI' => 'GitHub Actions Workflow (Reusable – Recommended)',
130130
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_EXPLAIN' => 'Creates a GitHub Actions workflow that uses a reusable, phpBB-maintained framework to run PHPUnit tests on your repository. The workflow file is saved in .github/workflows and runs automatically on each commit and pull request.',
131-
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_DEPRECATED' => 'Create a standalone GitHub Actions workflow [Deprecated: not recommended unless you plan to modify jobs or steps]',
132-
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_DEPRECATED_UI' => 'GitHub Actions Workflow (Standalone – Deprecated)',
133-
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_DEPRECATED_EXPLAIN' => 'Deprecated: Creates a fully standalone workflow to run PHPUnit tests without using the shared phpBB framework. This overrides the reusable workflow and is no longer recommended. The file is saved in .github/workflows and runs on each commit and pull request.',
131+
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_CUSTOM' => 'Create a standalone GitHub Actions workflow [Deprecated: not recommended unless you plan to modify jobs or steps]',
132+
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_CUSTOM_UI' => 'GitHub Actions Workflow (Standalone – Deprecated)',
133+
'SKELETON_QUESTION_COMPONENT_GITHUBACTIONS_CUSTOM_EXPLAIN' => 'Deprecated: Creates a fully standalone workflow to run PHPUnit tests without using the shared phpBB framework. This overrides the reusable workflow and is no longer recommended. The file is saved in .github/workflows and runs on each commit and pull request.',
134134
'SKELETON_QUESTION_COMPONENT_BUILD' => 'Create a sample build script for phing',
135135
'SKELETON_QUESTION_COMPONENT_BUILD_UI' => 'Build script (phing)',
136136
'SKELETON_QUESTION_COMPONENT_BUILD_EXPLAIN' => 'A phing build script is generated for your extension which can be used to generate build packages to help simplify the release or deployment processes.',

skeleton/.github/workflows/tests.yml.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Tests
22

3-
{% if COMPONENT.githubactions_deprecated %}
3+
{% if COMPONENT.githubactions_custom %}
44
env:
55
EXTNAME: {{ EXTENSION.vendor_name }}/{{ EXTENSION.extension_name }} # Your extension vendor/package name
66
SNIFF: 1 # Run code sniffer on your code? 1 or 0

0 commit comments

Comments
 (0)