Skip to content

Commit 5343eb5

Browse files
authored
Merge pull request #145 from iMattPro/updates
Maintenance
2 parents d13a6f1 + f56e4f9 commit 5343eb5

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

.github/workflows/tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ jobs:
127127
db: "mysql:5.7"
128128
- php: '8.3'
129129
db: "mysql:5.7"
130+
- php: '8.4'
131+
db: "mysql:5.7"
130132

131133
name: PHP ${{ matrix.php }} - ${{ matrix.db_alias != '' && matrix.db_alias || matrix.db }}
132134

@@ -270,6 +272,8 @@ jobs:
270272
db: "postgres:14"
271273
- php: '8.3'
272274
db: "postgres:14"
275+
- php: '8.4'
276+
db: "postgres:14"
273277

274278
name: PHP ${{ matrix.php }} - ${{ matrix.db }}
275279

ext.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ protected function phpbb_requirement()
6464
*/
6565
protected function php_requirement()
6666
{
67-
if (phpbb_version_compare(PHP_VERSION, '5.6.0', '<'))
67+
if (PHP_VERSION_ID < 50600)
6868
{
6969
$this->errors[] = 'PHP_VERSION_ERROR';
7070
}

skeleton/.github/workflows/tests.yml.twig

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,10 @@ jobs:
125125
db: "mysql:5.7"
126126
- php: '8.2'
127127
db: "mysql:5.7"
128-
- php: '8.3'
129-
db: "mysql:5.7"
128+
- php: '8.3'
129+
db: "mysql:5.7"
130+
- php: '8.4'
131+
db: "mysql:5.7"
130132

131133
name: PHP ${{ '{{' }} matrix.php }} - ${{ '{{' }} matrix.db_alias != '' && matrix.db_alias || matrix.db }}
132134

@@ -237,8 +239,10 @@ jobs:
237239
db: "postgres:14"
238240
- php: '8.2'
239241
db: "postgres:14"
240-
- php: '8.3'
241-
db: "postgres:14"
242+
- php: '8.3'
243+
db: "postgres:14"
244+
- php: '8.4'
245+
db: "postgres:14"
242246

243247
name: PHP ${{ '{{' }} matrix.php }} - ${{ '{{' }} matrix.db }}
244248

0 commit comments

Comments
 (0)