Skip to content

Commit 746255a

Browse files
committed
Set component installations to false by default
Closes #24
1 parent 32b3101 commit 746255a

3 files changed

Lines changed: 11 additions & 12 deletions

File tree

config/skeletons.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ services:
1010
class: phpbb\skeleton\skeleton
1111
arguments:
1212
- 'phplistener'
13-
- true
13+
- false
1414
- []
1515
- ['config/services.yml', 'event/main_listener.php']
1616
tags:
@@ -20,7 +20,7 @@ services:
2020
class: phpbb\skeleton\skeleton
2121
arguments:
2222
- 'htmllistener'
23-
- true
23+
- false
2424
- []
2525
- ['styles/prosilver/template/event/overall_header_navigation_prepend.html']
2626
tags:
@@ -30,7 +30,7 @@ services:
3030
class: phpbb\skeleton\skeleton
3131
arguments:
3232
- 'acp'
33-
- true
33+
- false
3434
- []
3535
- ['acp/main_info.php', 'acp/main_module.php', 'adm/style/acp_demo_body.html', 'language/en/info_acp_demo.php']
3636
tags:
@@ -40,7 +40,7 @@ services:
4040
class: phpbb\skeleton\skeleton
4141
arguments:
4242
- 'migration'
43-
- true
43+
- false
4444
- []
4545
- ['migrations/install_module.php', 'migrations/install_user_schema.php']
4646
tags:
@@ -50,7 +50,7 @@ services:
5050
class: phpbb\skeleton\skeleton
5151
arguments:
5252
- 'service'
53-
- true
53+
- false
5454
- []
5555
- ['service.php', 'config/services.yml', 'config/parameters.yml']
5656
tags:
@@ -60,7 +60,7 @@ services:
6060
class: phpbb\skeleton\skeleton
6161
arguments:
6262
- 'controller'
63-
- true
63+
- false
6464
- []
6565
- ['config/routing.yml', 'config/services.yml', 'event/main_listener.php', 'language/en/common.php', 'controller/main.php', 'styles/prosilver/template/demo_body.html']
6666
tags:
@@ -70,7 +70,7 @@ services:
7070
class: phpbb\skeleton\skeleton
7171
arguments:
7272
- 'ext'
73-
- true
73+
- false
7474
- []
7575
- ['ext.php']
7676
tags:
@@ -80,7 +80,7 @@ services:
8080
class: phpbb\skeleton\skeleton
8181
arguments:
8282
- 'tests'
83-
- true
83+
- false
8484
- []
8585
- ['tests/controller/main_test.php', 'tests/dbal/fixtures/config.xml', 'tests/dbal/simple_test.php', 'tests/functional/demo_test.php', 'phpunit.xml.dist']
8686
tags:
@@ -90,7 +90,7 @@ services:
9090
class: phpbb\skeleton\skeleton
9191
arguments:
9292
- 'travis'
93-
- true
93+
- false
9494
- ['tests']
9595
- ['travis/prepare-phpbb.sh', '.travis.yml']
9696
tags:

controller/main.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ protected function get_component_data()
196196
$components = $this->packager->get_component_dialog_values();
197197
foreach ($components as $component => $details)
198198
{
199-
$details['default'] = false;
200199
foreach ($details['dependencies'] as $depends)
201200
{
202201
if (empty($this->data['components'][$depends]))

language/en/common.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
'PHPBB_SKELETON_EXT' => 'Create skeleton extension',
2727

2828
'EXTENSION_CLI_SKELETON_SUCCESS' => "<info>Extension created successfully.\nCopy the extension from `store/tmp-ext/` into the `ext/` folder.</info>",
29-
'SKELETON_CLI_COMPOSER_QUESTIONS' => '<comment>Enter the composer.json details (hit enter to leave an option empty)</comment>',
30-
'SKELETON_CLI_COMPONENT_QUESTIONS' => '<comment>Choose the components you’d like installed. Default: y; [y/n]</comment>',
29+
'SKELETON_CLI_COMPOSER_QUESTIONS' => '<comment>Enter composer.json details (hit enter to leave an option empty)</comment>',
30+
'SKELETON_CLI_COMPONENT_QUESTIONS' => '<comment>Install optional components. Default: No; [y/n]</comment>',
3131

3232
'SKELETON_ADD_AUTHOR' => 'Add author',
3333
'SKELETON_QUESTION_VENDOR_NAME' => 'Please enter the vendor name',

0 commit comments

Comments
 (0)