Skip to content

Commit 89b7bbf

Browse files
committed
Skeleton not compatible with phpBB 4
Signed-off-by: Matt Friedman <maf675@gmail.com>
1 parent 3f406ed commit 89b7bbf

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"type": "phpbb-extension",
44
"description": "The official phpBB skeleton extension generator.",
55
"homepage": "https://www.phpbb.com/customise/db/official_tool/ext_skeleton/",
6-
"version": "1.1.11",
6+
"version": "1.1.12-dev",
77
"license": "GPL-2.0-only",
88
"authors": [
99
{
@@ -28,7 +28,7 @@
2828
"extra": {
2929
"display-name": "phpBB Skeleton Extension",
3030
"soft-require": {
31-
"phpbb/phpbb": ">=3.2.3"
31+
"phpbb/phpbb": ">=3.2.3,<4.0.0@dev"
3232
},
3333
"version-check": {
3434
"host": "www.phpbb.com",

ext.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,12 @@ protected function phpbb_requirement()
4848
{
4949
if (phpbb_version_compare(PHPBB_VERSION, '3.2.3', '<'))
5050
{
51-
$this->errors[] = 'PHPBB_VERSION_ERROR';
51+
$this->errors[] = 'PHPBB_VERSION_MIN_ERROR';
52+
}
53+
54+
else if (phpbb_version_compare(PHPBB_VERSION, '4.0.0-dev', '>='))
55+
{
56+
$this->errors[] = 'PHPBB_VERSION_MAX_ERROR';
5257
}
5358
}
5459

language/en/common.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,5 +156,6 @@
156156

157157
'NO_ZIPARCHIVE_ERROR' => 'The ZipArchive class is required, but was not found in your PHP configuration.',
158158
'PHP_VERSION_ERROR' => 'PHP 5.6 or newer is required to use this extension.',
159-
'PHPBB_VERSION_ERROR' => 'phpBB 3.2.3 or newer is required to use this extension.',
159+
'PHPBB_VERSION_MIN_ERROR' => 'phpBB 3.2.3 or newer is required to use this extension.',
160+
'PHPBB_VERSION_MAX_ERROR' => 'phpBB 4 is not supported with this version of the extension. Please check for a newer version of this extension.'
160161
]);

0 commit comments

Comments
 (0)