Skip to content

Commit 8f921b0

Browse files
committed
Fixes n stuff
1 parent 7a9c02c commit 8f921b0

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

console/create.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use phpbb\skeleton\helper\packager;
1919
use phpbb\skeleton\helper\validator;
2020
use phpbb\user;
21+
use Symfony\Component\Console\Exception\LogicException;
2122
use Symfony\Component\Console\Helper\QuestionHelper;
2223
use Symfony\Component\Console\Input\InputInterface;
2324
use Symfony\Component\Console\Output\OutputInterface;
@@ -85,13 +86,18 @@ protected function configure()
8586
* @param OutputInterface $output An OutputInterface instance
8687
*
8788
* @see \phpbb\config\config::delete()
88-
* @return void
89+
*
90+
* @return int 0 if everything went fine, or an exit code
91+
*
92+
* @throws LogicException When this abstract method is not implemented
8993
*/
9094
protected function execute(InputInterface $input, OutputInterface $output)
9195
{
9296
$this->packager->create_extension($this->data);
9397

9498
$output->writeln($this->language->lang('EXTENSION_CLI_SKELETON_SUCCESS'));
99+
100+
return 0;
95101
}
96102

97103
/**

tests/event_listener_test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,6 @@ public function test_add_page_header_link()
7878
$dispatcher = new \phpbb\event\dispatcher();
7979
$dispatcher->addListener('core.page_header', [$this->listener, 'add_page_header_link']);
8080

81-
$dispatcher->dispatch('core.page_header');
81+
$dispatcher->trigger_event('core.page_header');
8282
}
8383
}

0 commit comments

Comments
 (0)