Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
============================================
+ Coverage 95.57% 95.74% +0.16%
- Complexity 134 138 +4
============================================
Files 8 8
Lines 407 423 +16
============================================
+ Hits 389 405 +16
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves the extension’s UX by enhancing CLI presentation and making version/requirements errors more informative (including actual required/current versions).
Changes:
- Add a colored ASCII banner to the
extension:createCLI interaction flow. - Change requirement-check errors to carry parameters (required/current versions) and render them via localized messages with placeholders.
- Adjust unit test helper behavior to accommodate the new error structure.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/ext_test.php |
Normalizes errors entries for assertions now that errors can be parameterized arrays. |
language/en/common.php |
Adds CLI banner description string and updates requirement error messages to include placeholders for versions. |
ext.php |
Stores parameterized errors (key + args), renders them appropriately in enable_failed(), and adds a helper to format PHP version IDs. |
console/create.php |
Displays a colored ASCII banner at the start of interactive CLI prompting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.