Catch exceptions

Author: iMattPro

helper/helper.php

@@ -17,6 +17,7 @@
 use phpbb\pwakit\storage\storage;
 use phpbb\storage\exception\storage_exception;
 use phpbb\storage\helper as storage_helper;
+use RuntimeException;
 
 class helper
 {
@@ -65,11 +66,18 @@ public function __construct(ext_manager $extension_manager, FastImageSize $image
 	 */
 	public function is_storage_local(): bool
 	{
-		$current_provider = $this->provider_collection->get_by_class(
-			$this->storage_helper->get_current_provider($this->storage->get_name())
-		);
+		try
+		{
+			$storage_name = $this->storage->get_name();
+			$provider_class = $this->storage_helper->get_current_provider($storage_name);
+			$current_provider = $this->provider_collection->get_by_class($provider_class);
 
-		return $current_provider && $current_provider->get_name() === 'local';
+			return $current_provider && $current_provider->get_name() === 'local';
+		}
+		catch (RuntimeException)
+		{
+			return false;
+		}
 	}
 
 	/**

tests/unit/helper_test.php

@@ -159,6 +159,12 @@ public function test_is_storage_local()
 		$this->assertTrue($this->helper->is_storage_local());
 	}
 
+	public function test_is_storage_not_local()
+	{
+		$this->config->set('storage\phpbb_pwakit\provider', 'foo');
+		$this->assertFalse($this->helper->is_storage_local());
+	}
+
 	public function test_get_storage_path()
 	{
 		$this->assertEquals($this->storage_path, $this->helper->get_storage_path());