Skip to content

PWA image issue #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 2 commits into from
May 21, 2025
Merged

PWA image issue #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16ff9fb
Block opening attachments in PWA
iMattPro May 21, 2025
70589b7
Fix type hint order
iMattPro May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ext extends base
/**
* {@inheritdoc}
*/
public function is_enableable(): bool|array
public function is_enableable(): array|bool
{
$config = $this->container->get('config');
return $this->version_check($config['version']) && $this->version_check(PHPBB_VERSION);
Expand Down
18 changes: 18 additions & 0 deletions styles/all/template/event/overall_footer_body_after.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{# Disable opening attached images in Progressive Web Apps #}
{% if S_VIEWTOPIC %}
<script>
const isStandalone = window.matchMedia('(display-mode: standalone)').matches
|| window.navigator.standalone === true;

if (isStandalone) {
document.querySelectorAll('a > img.postimage').forEach(img => {
const link = img.closest('a');
if (link) {
link.addEventListener('click', e => {
e.preventDefault();
});
}
});
}
</script>
{% endif %}