Skip to content

Commit 93d5b9f

Browse files
committed
Some language clean up
1 parent b2c8645 commit 93d5b9f

3 files changed

Lines changed: 16 additions & 14 deletions

File tree

adm/style/wpn_acp_pwa.html

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ <h3>{{ lang('WARNING') }}</h3>
1313
</div>
1414
{% endif %}
1515

16+
{% set iconDir = constant('phpbb\\webpushnotifications\\ext::PWA_ICON_DIR') %}
17+
1618
<form id="webpushnotifications_pwa_settings" method="post" action="{{ U_ACTION }}">
1719
<fieldset>
1820
<legend>{{ lang('GENERAL_SETTINGS') }}</legend>
@@ -21,12 +23,12 @@ <h3>{{ lang('WARNING') }}</h3>
2123
<dd><input id="pwa_short_name" type="text" size="40" maxlength="12" name="config[pwa_short_name]" value="{{ PWA_SHORT_NAME }}"></dd>
2224
</dl>
2325
<dl>
24-
<dt><label for="pwa_icon_small">{{ lang('PWA_ICON_SMALL') ~ lang('COLON') }}</label><br><span>{{ lang('PWA_ICON_SMALL_EXPLAIN') }}</span></dt>
25-
<dd>{{ constant('phpbb\\webpushnotifications\\ext::PWA_ICON_DIR') }}/<input id="pwa_icon_small" type="text" size="40" maxlength="255" name="config[pwa_icon_small]" value="{{ PWA_ICON_SMALL }}"></dd>
26+
<dt><label for="pwa_icon_small">{{ lang('PWA_ICON_SMALL') ~ lang('COLON') }}</label><br><span>{{ lang('PWA_ICON_SMALL_EXPLAIN', iconDir) }}</span></dt>
27+
<dd>{{ iconDir }}/<input id="pwa_icon_small" type="text" size="40" maxlength="255" name="config[pwa_icon_small]" value="{{ PWA_ICON_SMALL }}"></dd>
2628
</dl>
2729
<dl>
28-
<dt><label for="pwa_icon_large">{{ lang('PWA_ICON_LARGE') ~ lang('COLON') }}</label><br><span>{{ lang('PWA_ICON_LARGE_EXPLAIN') }}</span></dt>
29-
<dd>{{ constant('phpbb\\webpushnotifications\\ext::PWA_ICON_DIR') }}/<input id="pwa_icon_large" type="text" size="40" maxlength="255" name="config[pwa_icon_large]" value="{{ PWA_ICON_LARGE }}"></dd>
30+
<dt><label for="pwa_icon_large">{{ lang('PWA_ICON_LARGE') ~ lang('COLON') }}</label><br><span>{{ lang('PWA_ICON_LARGE_EXPLAIN', iconDir) }}</span></dt>
31+
<dd>{{ iconDir }}/<input id="pwa_icon_large" type="text" size="40" maxlength="255" name="config[pwa_icon_large]" value="{{ PWA_ICON_LARGE }}"></dd>
3032
</dl>
3133
<dl>
3234
<dt><label>{{ lang('PWA_SHOW_INSTALL_BANNER') ~ lang('COLON') }}</label><br><span>{{ lang('PWA_SHOW_INSTALL_BANNER_EXPLAIN') }}</span></dt>

language/en/webpushnotifications_module_acp.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,14 @@
5656
'WEBPUSH_INSECURE_SERVER_ERROR' => 'This board is not using a secure SSL/HTTPS protocol, which is required for enabling web push notifications. Alternatively, the server environment might be misconfigured. Ensure that the <em>HTTPS</em> and <em>HEADER_CLIENT_PROTO</em> server environment variables are correctly configured.',
5757

5858
// PWA Settings
59-
'ACP_PWA_SETTINGS_EXPLAIN' => 'Here you can configure Progressive Web App behaviour, including app manifest metadata and install banner display.',
59+
'ACP_PWA_SETTINGS_EXPLAIN' => 'Here you can configure Progressive Web App (PWA) features, including app metadata, icons, theme colours, and install prompts.',
6060
'PWA_SHORT_NAME' => 'Short site name',
6161
'PWA_SHORT_NAME_EXPLAIN' => 'Your site name in 12 characters or fewer, which may be used as a label for an icon on a mobile device’s home screen. (If this field is left empty, the first 12 characters of the <samp>Site name</samp> will be used.)',
6262
'PWA_SHORT_NAME_INVALID' => '“Short site name” exceeds the 12 character limit.',
6363
'PWA_ICON_SMALL' => 'Small mobile device icon',
64-
'PWA_ICON_SMALL_EXPLAIN' => 'File name of a 192px x 192px PNG image. This file must be uploaded to your board’s <samp>' . \phpbb\webpushnotifications\ext::PWA_ICON_DIR . '</samp> directory.',
64+
'PWA_ICON_SMALL_EXPLAIN' => 'File name of a 192px x 192px PNG image. This file must be uploaded to your board’s <samp>%s</samp> directory.',
6565
'PWA_ICON_LARGE' => 'Large mobile device icon',
66-
'PWA_ICON_LARGE_EXPLAIN' => 'File name of a 512px x 512px PNG image. This file must be uploaded to your board’s <samp>' . \phpbb\webpushnotifications\ext::PWA_ICON_DIR . '</samp> directory.',
66+
'PWA_ICON_LARGE_EXPLAIN' => 'File name of a 512px x 512px PNG image. This file must be uploaded to your board’s <samp>%s</samp> directory.',
6767
'PWA_ICON_SIZE_INVALID' => '“%s” does not have the correct image dimensions.',
6868
'PWA_ICON_MIME_INVALID' => '“%s” must be a PNG image file.',
6969
'PWA_ICON_INVALID' => '“%s” is not a valid image file or is missing from the expected location. Verify the file name and location are correct.',
@@ -74,6 +74,6 @@
7474
'PWA_THEME_COLOUR' => 'Theme colour',
7575
'PWA_BACKGROUND_COLOUR' => 'Background colour',
7676
'PWA_INVALID_COLOUR' => 'The colour code “<samp>%s</samp>” is not a valid hex code.',
77-
'PWA_SHOW_INSTALL_BANNER' => 'Show install banner',
78-
'PWA_SHOW_INSTALL_BANNER_EXPLAIN' => 'Display a mobile install prompt when the browser reports that your board can be installed as an app.',
77+
'PWA_SHOW_INSTALL_BANNER' => 'Show app install banner',
78+
'PWA_SHOW_INSTALL_BANNER_EXPLAIN' => 'Display a prompt on supported mobile devices inviting users to install your board as an app.',
7979
]);

language/ru/webpushnotifications_module_acp.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,14 @@
5656
'WEBPUSH_INSECURE_SERVER_ERROR' => 'На данной конференции не применяется защищённый протокол SSL/HTTPS, без которого использование браузерных push—уведомлений невозможно, либо соответствующие переменные серверного окружения неверно сконфигурированы. Убедитесь, что значения переменных серверного окружения <em>HTTPS</em> и/или <em>HEADER_CLIENT_PROTO</em> заданы верно.',
5757

5858
// PWA Settings
59-
'ACP_PWA_SETTINGS_EXPLAIN' => 'Here you can configure Progressive Web App behaviour, including app manifest metadata and install banner display.',
59+
'ACP_PWA_SETTINGS_EXPLAIN' => 'Here you can configure Progressive Web App (PWA) features, including app metadata, icons, theme colours, and install prompts.',
6060
'PWA_SHORT_NAME' => 'Short site name',
6161
'PWA_SHORT_NAME_EXPLAIN' => 'Your site name in 12 characters or fewer, which may be used as a label for an icon on a mobile device’s home screen. (If this field is left empty, the first 12 characters of the <samp>Site name</samp> will be used.)',
6262
'PWA_SHORT_NAME_INVALID' => '“Short site name” exceeds the 12 character limit.',
6363
'PWA_ICON_SMALL' => 'Small mobile device icon',
64-
'PWA_ICON_SMALL_EXPLAIN' => 'File name of a 192px x 192px PNG image. This file must be uploaded to your board’s <samp>' . \phpbb\webpushnotifications\ext::PWA_ICON_DIR . '</samp> directory.',
64+
'PWA_ICON_SMALL_EXPLAIN' => 'File name of a 192px x 192px PNG image. This file must be uploaded to your board’s <samp>%s</samp> directory.',
6565
'PWA_ICON_LARGE' => 'Large mobile device icon',
66-
'PWA_ICON_LARGE_EXPLAIN' => 'File name of a 512px x 512px PNG image. This file must be uploaded to your board’s <samp>' . \phpbb\webpushnotifications\ext::PWA_ICON_DIR . '</samp> directory.',
66+
'PWA_ICON_LARGE_EXPLAIN' => 'File name of a 512px x 512px PNG image. This file must be uploaded to your board’s <samp>%s</samp> directory.',
6767
'PWA_ICON_SIZE_INVALID' => '“%s” does not have the correct image dimensions.',
6868
'PWA_ICON_MIME_INVALID' => '“%s” must be a PNG image file.',
6969
'PWA_ICON_INVALID' => '“%s” is not a valid image file or is missing from the expected location. Verify the file name and location are correct.',
@@ -74,6 +74,6 @@
7474
'PWA_THEME_COLOUR' => 'Theme colour',
7575
'PWA_BACKGROUND_COLOUR' => 'Background colour',
7676
'PWA_INVALID_COLOUR' => 'The colour code “<samp>%s</samp>” is not a valid hex code.',
77-
'PWA_SHOW_INSTALL_BANNER' => 'Show install banner',
78-
'PWA_SHOW_INSTALL_BANNER_EXPLAIN' => 'Display a mobile install prompt when the browser reports that your board can be installed as an app.',
77+
'PWA_SHOW_INSTALL_BANNER' => 'Show app install banner',
78+
'PWA_SHOW_INSTALL_BANNER_EXPLAIN' => 'Display a prompt on supported mobile devices inviting users to install your board as an app.',
7979
]);

0 commit comments

Comments
 (0)