Skip to content

Prep 1.0.3 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 5 commits into from
Sep 26, 2025
Merged

Prep 1.0.3 #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40ac624
Prep 1.0.3
iMattPro May 20, 2025
88d2f60
Merge branch 'main' into prep-1.0.3
iMattPro May 21, 2025
7dd4c21
Update changelog
iMattPro May 21, 2025
932baad
Re-label phpBB3 in tests
iMattPro May 27, 2025
db7c5cc
Fix tests
iMattPro Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

### 1.0.3 - 2025-05-21

- Fixed issues where opening an image attachment could lock you out of the UI while on a mobile device as a progressive web app.
- Fixed issues where Safari would stop pushing notifications to a user after the first three.
- Fixed attempts to notify banned users.
- Fixed potential web root path issues in notification links.
- Removed obsolete meta-tags for progressive web app functionality.

### 1.0.2 - 2025-01-04

- Instead of blocking all bots, we now let reverse proxies know we detected a bot.
Expand All @@ -12,13 +20,13 @@

### 1.0.1 - 2024-09-30

- Added FAQ section to phpBB's FAQ page to answer any questions users may have about web push notifications.
- Added a FAQ section to phpBB's FAQ page to answer any questions users may have about web push notifications.
- Fixed issues with Emoji not appearing correctly in push notifications.
- Fixed possible issues with the URLs linking to PWA icons for the Web Manifest.
- Fixed issues causing logged-out users to see console errors in their browsers.
- Ensure short site name for PWA is valid and compatible with the Web Manifest.
- Fixed the issues causing logged-out users to see console errors in their browsers.
- Ensure the short site name for PWA is valid and compatible with the Web Manifest.
- Will now check for required PHP modules during installation.
- Various other under the hood improvements.
- Various other under-the hood improvements.

### 1.0.0 - 2024-07-01

Expand All @@ -35,7 +43,7 @@

### 1.0.0-RC9 - 2024-06-16

- The subscribe toggle in the notification dropdown has been optimized for better mobile usability.
- The **subscribe** toggle in the notification dropdown has been optimized for better mobile usability.
- Notifications missed by logged-out users will now be delivered once they log back in.
- Users who are unable to subscribe due to previously denying notifications in their browser settings will now see an alert message.

Expand All @@ -53,7 +61,7 @@

### 1.0.0-RC6 - 2024-06-01

- New: Added an enable push subscriptions toggle switch to the footer of the Notifications drop down.
- New: Added an **enable push subscriptions** toggle switch to the footer of the Notifications drop down.
- Fixed an issue where the Subscribe button was appearing on some UCP pages unexpectedly.
- Fixed an issue where push notifications failed on Android devices using Firefox as their browser.
- Requires phpBB 3.3.12 or newer.
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"type": "phpbb-extension",
"description": "An official phpBB extension that allows board users to receive browser-based push notifications.",
"homepage": "https://www.phpbb.com/customise/db/extension/webpushnotifications/",
"version": "1.0.2",
"version": "1.0.3",
"license": "GPL-2.0-only",
"authors": [
{
Expand Down
2 changes: 1 addition & 1 deletion composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions tests/controller/controller_webpush_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ private function getExpectedResponse(): array
return [
'heading' => 'yourdomain.com',
'title' => 'Quoted by Guest in:',
'text' => '"Welcome to phpBB3"',
'text' => '"Welcome to phpBB"',
'url' => 'phpBB/viewtopic.php?p=1#p1',
'avatar' => ['src' => ''],
];
Expand Down Expand Up @@ -242,7 +242,7 @@ public function test_get_user_notification()
$this->request->method('variable')
->willReturnMap([
['token', '', false, request_interface::REQUEST, 'foobar'],
['item_id', 0, false, request_interface::REQUEST, 1],
['item_id', 0, false, request_interface::REQUEST, 2],
['type_id', 0, false, request_interface::REQUEST, 4],
]);
$this->setupUserData(2);
Expand All @@ -262,7 +262,7 @@ public function test_get_user_notification_anonymous()
$this->request->method('variable')
->willReturnMap([
['token', '', false, request_interface::REQUEST, '0ccf8fcd96a66297b77b66109cbe9870e1a6fa66e42b9bf36d1f2c7263240058'],
['item_id', 0, false, request_interface::REQUEST, 1],
['item_id', 0, false, request_interface::REQUEST, 2],
['type_id', 0, false, request_interface::REQUEST, 4],
['user_id', 0, false, request_interface::REQUEST, 2],
]);
Expand All @@ -283,7 +283,7 @@ public function test_get_user_notification_anonymous_invalid_token()
$this->request->method('variable')
->willReturnMap([
['token', '', false, request_interface::REQUEST, '488c17afe4f18714c235b395e21b78df1c3d78bf1e13d0633ed9425d2eebf967'],
['item_id', 0, false, request_interface::REQUEST, 1],
['item_id', 0, false, request_interface::REQUEST, 2],
['type_id', 0, false, request_interface::REQUEST, 4],
['user_id', 0, false, request_interface::REQUEST, 2],
]);
Expand Down
4 changes: 2 additions & 2 deletions tests/controller/fixtures/webpush.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@
<column>notification_time</column>
<row>
<value>1</value>
<value><![CDATA[{"item_id":1,"notification_type_id":4,"item_parent_id":1,"notification_time":1738437884,"notification_read":false,"notification_data":"a:6:{s:9:\"poster_id\";i:3;s:11:\"topic_title\";s:17:\"Welcome to phpBB3\";s:12:\"post_subject\";s:21:\"Re: Welcome to phpBB3\";s:13:\"post_username\";s:0:\"\";s:8:\"forum_id\";i:2;s:10:\"forum_name\";s:16:\"Your first forum\";}","user_id":2,"notification_type_name":"notification.type.quote"}]]></value>
<value><![CDATA[{"item_id":1,"notification_type_id":4,"item_parent_id":1,"notification_time":1738437884,"notification_read":false,"notification_data":"a:6:{s:9:\"poster_id\";i:3;s:11:\"topic_title\";s:17:\"Welcome to phpBB\";s:12:\"post_subject\";s:21:\"Re: Welcome to phpBB\";s:13:\"post_username\";s:0:\"\";s:8:\"forum_id\";i:2;s:10:\"forum_name\";s:16:\"Your first forum\";}","user_id":2,"notification_type_name":"notification.type.quote"}]]></value>
<value>488c17afe4f18714c235b395e21b78df1c3d78bf1e13d0633ed9425d2eebf967</value>
<value>2</value>
<value>4</value>
<value>1738437884</value>
</row>
<row>
<value>2</value>
<value><![CDATA[{"heading":"yourdomain.com","title":"Quoted by Guest in:","text":"\"Welcome to phpBB3\"","url":"phpBB\/viewtopic.php?p=1#p1","avatar":{"src":""}}]]></value>
<value><![CDATA[{"heading":"yourdomain.com","title":"Quoted by Guest in:","text":"\"Welcome to phpBB\"","url":"phpBB\/viewtopic.php?p=1#p1","avatar":{"src":""}}]]></value>
<value>488c17afe4f18714c235b395e21b78df1c3d78bf1e13d0633ed9425d2eebf967</value>
<value>2</value>
<value>4</value>
Expand Down
Loading