Update some tests

Signed-off-by: Matt Friedman <maf675@gmail.com>

Author: iMattPro

tests/ext_test.php

@@ -10,33 +10,90 @@
 
 namespace phpbb\ideas\tests;
 
+use PHPUnit\Framework\MockObject\MockObject;
+use phpbb\notification\manager;
+use phpbb\finder;
+use phpbb\db\migrator;
+use Symfony\Component\DependencyInjection\ContainerInterface;
+use phpbb\ideas\ext;
+
 class ext_test extends \phpbb_test_case
 {
-	public function test_ext()
+	/** @var ext */
+	private $ext;
+
+	/** @var MockObject|manager */
+	private $notification_manager;
+
+	/** @var MockObject|ContainerInterface */
+	private $container;
+
+	/** @var MockObject|finder */
+	private $extension_finder;
+
+	/** @var MockObject|migrator */
+	private $migrator;
+
+	protected function setUp(): void
 	{
-		/** @var \PHPUnit\Framework\MockObject\MockObject|\Symfony\Component\DependencyInjection\ContainerInterface $container */
-		$container = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
-			->disableOriginalConstructor()
-			->getMock();
-
-		/** @var \PHPUnit\Framework\MockObject\MockObject|\phpbb\finder $extension_finder */
-		$extension_finder = $this->getMockBuilder('\phpbb\finder')
-			->disableOriginalConstructor()
-			->getMock();
-
-		/** @var \PHPUnit\Framework\MockObject\MockObject|\phpbb\db\migrator $migrator */
-		$migrator = $this->getMockBuilder('\phpbb\db\migrator')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$ext = new \phpbb\ideas\ext(
-			$container,
-			$extension_finder,
-			$migrator,
+		parent::setUp();
+		$this->initialize_mocks();
+		$this->create_extension();
+	}
+
+	private function initialize_mocks(): void
+	{
+		$this->notification_manager = $this->createMock(manager::class);
+		$this->container = $this->createMock(ContainerInterface::class);
+		$this->extension_finder = $this->createMock(finder::class);
+		$this->migrator = $this->createMock(migrator::class);
+	}
+
+	private function create_extension(): void
+	{
+		$this->ext = new ext(
+			$this->container,
+			$this->extension_finder,
+			$this->migrator,
 			'phpbb/ideas',
 			''
 		);
+	}
 
-		self::assertTrue($ext->is_enableable());
+	private function setup_notification_manager(string $method): void
+	{
+		$this->container->expects($this->once())
+			->method('get')
+			->with('notification_manager')
+			->willReturn($this->notification_manager);
+
+		$this->notification_manager->expects($this->once())
+			->method($method)
+			->with('phpbb.ideas.notification.type.status');
+	}
+
+	public function test_is_enableable(): void
+	{
+		$this->assertTrue($this->ext->is_enableable());
+	}
+
+	/**
+	 * @dataProvider notification_step_provider
+	 */
+	public function test_notification_steps(string $method, string $step): void
+	{
+		$this->setup_notification_manager($method);
+
+		$state = $this->ext->$step(false);
+		$this->assertEquals('notification', $state);
+	}
+
+	public function notification_step_provider(): array
+	{
+		return [
+			'enable step'  => ['enable_notifications', 'enable_step'],
+			'disable step' => ['disable_notifications', 'disable_step'],
+			'purge step'   => ['purge_notifications', 'purge_step']
+		];
 	}
 }