Use a notification custom identifier

Signed-off-by: Matt Friedman <maf675@gmail.com>

Author: iMattPro

factory/idea.php

@@ -71,7 +71,11 @@ public function set_status($idea_id, $status)
 
 		$this->update_idea_data($sql_ary, $idea_id, $this->table_ideas);
 
+		// Send a notification
+		// Increment our notifications sent counter
+		$this->config->increment('ideas_status_notifications_id', 1);
 		$this->notification_manager->add_notifications('phpbb.ideas.notification.type.status', [
+			'item_id' => $this->config['ideas_status_notifications_id'],
 			'idea_id' => (int) $idea_id,
 			'status'  => (int) $status,
 		]);

migrations/m14_notification_data.php

@@ -0,0 +1,34 @@
+<?php
+/**
+ *
+ * Ideas extension for the phpBB Forum Software package.
+ *
+ * @copyright (c) phpBB Limited <https://www.phpbb.com>
+ * @license GNU General Public License, version 2 (GPL-2.0)
+ *
+ */
+
+namespace phpbb\ideas\migrations;
+
+class m14_notification_data extends \phpbb\db\migration\migration
+{
+	public function effectively_installed()
+	{
+		return $this->config->offsetExists('ideas_status_notifications_id');
+	}
+
+	public static function depends_on()
+	{
+		return [
+			'\phpbb\ideas\migrations\m1_initial_schema',
+			'\phpbb\ideas\migrations\m13_set_permissions'
+		];
+	}
+
+	public function update_data()
+	{
+		return [
+			['config.add', ['ideas_status_notifications_id', 0, true]],
+		];
+	}
+}

notification/type/status.php

@@ -109,7 +109,7 @@ public function is_available()
 	 */
 	public static function get_item_id($type_data)
 	{
-		return (int) ($type_data['idea_id'] . $type_data['status']);
+		return (int) $type_data['item_id'];
 	}
 
 	/**