Update notification class

Author: iMattPro

config/services.yml

@@ -130,6 +130,6 @@ services:
         parent: notification.type.base
         shared: false
         calls:
-            - [set_additional_services, ['@config', '@controller.helper', '@user_loader']]
+            - [set_additional_services, ['@config', '@user_loader']]
         tags:
             - { name: notification.type }

notification/type/status.php

@@ -11,7 +11,6 @@
 namespace phpbb\ideas\notification\type;
 
 use phpbb\config\config;
-use phpbb\controller\helper;
 use phpbb\ideas\ext;
 use phpbb\user_loader;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
@@ -24,9 +23,6 @@ class status extends \phpbb\notification\type\base
 	/** @var config */
 	protected $config;
 
-	/** @var helper */
-	protected $helper;
-
 	/** @var user_loader */
 	protected $user_loader;
 
@@ -37,13 +33,11 @@ class status extends \phpbb\notification\type\base
 	 * Set additional services and properties
 	 *
 	 * @param config $config
-	 * @param helper $helper
 	 * @param user_loader $user_loader
 	 * @return void
 	 */
-	public function set_additional_services(config $config, helper $helper, user_loader $user_loader)
+	public function set_additional_services(config $config, user_loader $user_loader)
 	{
-		$this->helper = $helper;
 		$this->user_loader = $user_loader;
 		$this->ideas_forum_id = (int) $config['ideas_forum_id'];
 	}
@@ -168,7 +162,7 @@ public function get_url($reference_type = UrlGeneratorInterface::ABSOLUTE_PATH)
 	{
 		$params = ['idea_id' => $this->get_data('idea_id')];
 
-		return $this->helper->route('phpbb_ideas_idea_controller', $params, true, false, $reference_type);
+		return $this->controller_helper->route('phpbb_ideas_idea_controller', $params, true, false, $reference_type);
 	}
 
 	/**

tests/notification/status_test.php

@@ -54,15 +54,18 @@ protected function setUp(): void
 		$user = new \phpbb\user($this->language, '\phpbb\datetime');
 		$user->data['user_options'] = 230271;
 		$cache = new \phpbb_mock_cache();
+		$avatar_helper = $this->getMockBuilder('\phpbb\avatar\helper')
+			->disableOriginalConstructor()
+			->getMock();
 
 		$this->forum_id = 5;
 		$this->config->expects($this->once())
 			->method('offsetGet')
 			->with('ideas_forum_id')
 			->willReturn($this->forum_id);
 
-		$this->notification_type = new status($db, $this->language, $user, $this->auth, $phpbb_root_path, $phpEx, 'phpbb_user_notifications');
-		$this->notification_type->set_additional_services($this->config, $this->helper, $this->user_loader);
+		$this->notification_type = new status($avatar_helper, $this->helper, $db, $this->language, $user, $this->auth, $phpbb_root_path, $phpEx, 'phpbb_user_notifications');
+		$this->notification_type->set_additional_services($this->config, $this->user_loader);
 
 		// Set protected properties using reflection
 		$reflection = new \ReflectionClass($this->notification_type);