Skip to content

Commit a1b83a2

Browse files
committed
Allow build failure on PHP 7.4 because bug in spipu/html2pdf
See spipu/html2pdf#530
1 parent 0da4ecf commit a1b83a2

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

.travis.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,19 @@ language: php
22

33
php: ["7.0", "7.1", "7.2", "7.3", "7.4"]
44

5+
jobs:
6+
allow_failures:
7+
- php: 7.4 # there is a problem with html2pdf, see https://github.com/spipu/html2pdf/issues/530
8+
59
addons:
610
apt:
711
packages:
812
- poppler-utils
913

1014
env:
1115
global:
12-
- BUILD_COVERAGE_PHP_VERSION="7.4"
13-
- BUILD_PHAR_PHP_VERSION="7.4"
16+
- BUILD_COVERAGE_PHP_VERSION="7.3"
17+
- BUILD_PHAR_PHP_VERSION="7.3"
1418
- BUILD_PHAR_OUTPUT="build/cfditopdf.phar"
1519

1620
before_script:

docs/TODO.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ Intro: Al completar una tarea pasarla de *Planeada* a *Finalizada*. Escribir fec
44

55
# Planeadas
66

7+
- Revisar que <https://github.com/spipu/html2pdf/issues/530> esté solucionado para desactivar "permitir fallos"
8+
en PHP 7.4 porque `spipu/html2pdf` tiene un bug.
79
- Cambiar a PHP 7.2 o mayor.
810
- Al cambiar de versión de PHP, actualizar los métodos que retornan void a que explícitamente lo hangan.
911
- Modificar `NodeInterface<NodeInterface>` para cuando `eclipxe/cfdiutils` ya lo incluya por sí mismo.

0 commit comments

Comments
 (0)