Destructor improvement (#91)

* ci: upgrade workflow

* tweak: only close handle if it is open

Author: g105b

.github/workflows/ci.yml

@@ -1,13 +1,18 @@
 name: CI
 
-on: [push]
+on: [push, pull_request]
+
+permissions:
+  contents: read
+  actions: read
+  id-token: none
 
 jobs:
   composer:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php: [ 8.4 ]
+        php: [ 8.4, 8.5 ]
 
     steps:
       - uses: actions/checkout@v4
@@ -31,13 +36,14 @@ jobs:
         with:
           name: build-artifact-${{ matrix.php }}
           path: /tmp/github-actions
+          retention-days: 1
 
   phpunit:
     runs-on: ubuntu-latest
     needs: [ composer ]
     strategy:
       matrix:
-        php: [ 8.4 ]
+        php: [ 8.4, 8.5 ]
 
     outputs:
       coverage: ${{ steps.store-coverage.outputs.coverage_text }}
@@ -72,7 +78,7 @@ jobs:
     needs: [ phpunit ]
     strategy:
       matrix:
-        php: [ 8.4 ]
+        php: [ 8.4, 8.5 ]
 
     steps:
       - uses: actions/checkout@v4
@@ -87,16 +93,13 @@ jobs:
 
       - name: Upload to Codecov
         uses: codecov/codecov-action@v5
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          slug: PhpGt/Http
 
   phpstan:
     runs-on: ubuntu-latest
     needs: [ composer ]
     strategy:
       matrix:
-        php: [ 8.4 ]
+        php: [ 8.4, 8.5 ]
 
     steps:
       - uses: actions/download-artifact@v4
@@ -111,15 +114,14 @@ jobs:
         uses: php-actions/phpstan@v3
         with:
           php_version: ${{ matrix.php }}
-          level: 6
           path: src/
 
   phpmd:
     runs-on: ubuntu-latest
     needs: [ composer ]
     strategy:
       matrix:
-        php: [ 8.4 ]
+        php: [ 8.4, 8.5 ]
 
     steps:
       - uses: actions/download-artifact@v4
@@ -143,7 +145,7 @@ jobs:
     needs: [ composer ]
     strategy:
       matrix:
-        php: [ 8.4 ]
+        php: [ 8.4, 8.5 ]
 
     steps:
       - uses: actions/download-artifact@v4
@@ -160,22 +162,3 @@ jobs:
           php_version: ${{ matrix.php }}
           path: src/
           standard: phpcs.xml
-
-  remove_old_artifacts:
-    runs-on: ubuntu-latest
-
-    permissions:
-      actions: write
-
-    steps:
-      - name: Remove old artifacts for prior workflow runs on this repository
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          gh api "/repos/${{ github.repository }}/actions/artifacts" | jq ".artifacts[] | select(.name | startswith(\"build-artifact\")) | .id" > artifact-id-list.txt
-          while read id
-          do
-            echo -n "Deleting artifact ID $id ... "
-            gh api --method DELETE /repos/${{ github.repository }}/actions/artifacts/$id && echo "Done"
-          done <artifact-id-list.txt
-  

.gitignore

@@ -1,4 +1,6 @@
 /.idea
 /vendor
 /*.phar
-/test/unit/_coverage
+/test/unit/_coverage
+# Local wiki symlink
+docs