Remove rel quick-download and add the download attribute to download buttons

Author: williamdes

pmaweb/templates/_dlbox.html

@@ -1,3 +1,3 @@
 {% with release.simpledownload as file %}
-    <a class="btn btn-success download_popup" href="{{ file.get_absolute_url }}" title="Download {{ file.archive }} compressed release, {{ file.size | filesizeformat }}" rel="quick-download" data-sha256="{{ file.sha256 }}" data-pgp="{{ file.get_signed_url }}"><svg class="bi"><use href="#download"></use></svg> Download {{ release.version }}</a>
+    <a class="btn btn-success download_popup" href="{{ file.get_absolute_url }}" title="Download {{ file.archive }} compressed release, {{ file.size | filesizeformat }}" data-sha256="{{ file.sha256 }}" data-pgp="{{ file.get_signed_url }}" download><svg class="bi"><use href="#download"></use></svg> Download {{ release.version }}</a>
 {% endwith %}

pmaweb/templates/_dlrow.html

@@ -1,21 +1,21 @@
     <tr {% if file.is_featured %}class="featured-dl"{% endif %}>
     {% if latest %}
-        <td><a href="{{ file.get_stable_url }}" class="download_popup" data-sha256="{{ file.sha256 }}" data-pgp="{% if file.signed %}{{ file.get_stable_url }}.asc{% endif %}">{{ file.get_stable_filename }}</a></td>
+        <td><a href="{{ file.get_stable_url }}" class="download_popup" title="Download {{ file.archive }} compressed release, {{ file.size | filesizeformat }}" data-sha256="{{ file.sha256 }}" data-pgp="{% if file.signed %}{{ file.get_stable_url }}.asc{% endif %}" download>{{ file.get_stable_filename }}</a></td>
     {% else %}
-        <td><a href="{{ file.get_absolute_url }}" class="download_popup" data-sha256="{{ file.sha256 }}" data-pgp="{{ file.get_signed_url }}">{{ file.filename }}</a></td>
+        <td><a href="{{ file.get_absolute_url }}" class="download_popup" title="Download {{ file.archive }} compressed release, {{ file.size | filesizeformat }}" data-sha256="{{ file.sha256 }}" data-pgp="{{ file.get_signed_url }}" download>{{ file.filename }}</a></td>
     {% endif %}
         <td class="td-size">{{ file.size | filesizeformat }}</td>
         <td>
     {% if latest %}
         {% if file.signed %}
-        [<a href="{{ file.get_stable_url }}.asc">PGP</a>]
+        [<a href="{{ file.get_stable_url }}.asc" download>PGP</a>]
         {% endif %}
-        [<a href="{{ file.get_stable_url }}.sha256">SHA256</a>]
+        [<a href="{{ file.get_stable_url }}.sha256" download>SHA256</a>]
     {% else %}
         {% if file.signed %}
-        [<a href="{{ file.get_signed_url }}">PGP</a>]
+        [<a href="{{ file.get_signed_url }}" download>PGP</a>]
         {% endif %}
-        [<a href="{{ file.get_checksum_url }}">SHA256</a>]
+        [<a href="{{ file.get_checksum_url }}" download>SHA256</a>]
     {% endif %}
         </td>
     </tr>

pmaweb/templates/base.html

@@ -103,7 +103,7 @@ <h1 class="modal-title fs-5" id="downloadModalLabel">Thank you for downloading p
       </div>
       <div class="modal-body">
         <p>
-        Your download should start soon, if not please <a id="dl-link" href="">click here</a>.
+        Your download should start soon, if not please <a id="dl-link" href="" download>click here</a>.
         </p>
 
         <h4>Please verify the downloaded file</h4>
@@ -112,7 +112,7 @@ <h4>Please verify the downloaded file</h4>
         you can verify it using the following methods:
         </p>
         <ul>
-        <li id="dl-li-pgp">Verify its <a id="dl-pgp" href="">PGP signature</a>, see the <a href="https://docs.phpmyadmin.net/en/latest/setup.html#verifying-phpmyadmin-releases">Verifying phpMyAdmin releases</a> chapter for more information.</li>
+        <li id="dl-li-pgp">Verify its <a id="dl-pgp" href="" download>PGP signature</a>, see the <a href="https://docs.phpmyadmin.net/en/latest/setup.html#verifying-phpmyadmin-releases">Verifying phpMyAdmin releases</a> chapter for more information.</li>
         <li>Check that the file's SHA256 hash matches <code id="dl-sha256"></code></li>
         </ul>
 

pmaweb/templates/files/release_list.html

@@ -4,7 +4,7 @@
 
 <p>Archive of phpMyAdmin releases, you can find currently supported versions <a href="{% url 'downloads' %}">on downloads page</a>.</p>
 
-<table class="table table-condensed table-striped"> 
+<table class="table table-condensed table-striped">
 <thead>
 <tr>
     <th>Release</th>
@@ -21,7 +21,7 @@
     <td>{{ object.date|date:"Y-m-d" }}</td>
 {% with object.simpledownload as file %}
 {% if file %}
-    <td><a href="{{ file.get_absolute_url }}">{{ file.filename }}</a></td>
+    <td><a href="{{ file.get_absolute_url }}" title="Download {{ file.archive }} compressed release, {{ file.size | filesizeformat }}" data-sha256="{{ file.sha256 }}" data-pgp="{{ file.get_signed_url }}" download>{{ file.filename }}</a></td>
         <td class="size">{{ file.size | filesizeformat }}</td>
         <td>
         {% if file.signed %}