Regression tests

Closes phpstan/phpstan#5984
Closes phpstan/phpstan#9400

Author: ondrejmirtes

tests/PHPStan/Analyser/nsrt/bug-9400.php

@@ -0,0 +1,14 @@
+<?php declare(strict_types = 1);
+
+namespace Bug9400;
+
+use RuntimeException;
+use function PHPStan\Testing\assertType;
+
+function foo(string $foo): void
+{
+	if (!ctype_digit($foo) || ($foo = intval($foo)) < 1) {
+		throw new RuntimeException();
+	}
+	assertType('int<1, max>', $foo);
+}

tests/PHPStan/Rules/Comparison/BooleanNotConstantConditionRuleTest.php

@@ -223,4 +223,10 @@ public function testReportAlwaysTrueInLastCondition(bool $reportAlwaysTrueInLast
 		$this->analyse([__DIR__ . '/data/boolean-not-report-always-true-last-condition.php'], $expectedErrors);
 	}
 
+	public function testBug5984(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-5984.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-5984.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace Bug5984;
+
+interface LineScanner
+{
+	function isDone(): bool;
+	/**
+	 * @phpstan-impure
+	 */
+	function scanChar(string $char): bool;
+	/**
+	 * @phpstan-impure
+	 */
+	function readChar(): string;
+
+	function getColumn(): int;
+}
+
+class Test
+{
+	public function minimumIndentation(LineScanner $scanner): ?int
+	{
+		if ($scanner->isDone() || $scanner->scanChar("\n")) {
+			return null;
+		}
+
+		$min = $scanner->getColumn();
+
+		while (!$scanner->isDone() && $scanner->readChar() !== "\n") {
+		}
+
+		return $min;
+	}
+}