Fix phpstan/phpstan#13029: False match.unhandled on array with multiple booleans (phpstan#5107)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vincent Langlet <vincentlanglet@hotmail.fr>

Author: 3 people

src/Type/TypeCombinator.php

@@ -90,11 +90,13 @@ public static function remove(Type $fromType, Type $typeToRemove): Type
 		$fromFiniteTypes = $fromType->getFiniteTypes();
 		if (count($fromFiniteTypes) > 0) {
 			$finiteTypesToRemove = $typeToRemove->getFiniteTypes();
-			if (count($finiteTypesToRemove) === 1) {
+			if (count($finiteTypesToRemove) > 0) {
 				$result = [];
 				foreach ($fromFiniteTypes as $finiteType) {
-					if ($finiteType->equals($finiteTypesToRemove[0])) {
-						continue;
+					foreach ($finiteTypesToRemove as $finiteTypeToRemove) {
+						if ($finiteType->equals($finiteTypeToRemove)) {
+							continue 2;
+						}
 					}
 
 					$result[] = $finiteType;

tests/PHPStan/Rules/Comparison/MatchExpressionRuleTest.php

@@ -446,6 +446,12 @@ public function testBug9534(): void
 		]);
 	}
 
+	#[RequiresPhp('>= 8.0')]
+	public function testBug13029(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13029.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.0')]
 	public function testBug11310(): void
 	{

tests/PHPStan/Rules/Comparison/data/bug-13029.php

@@ -0,0 +1,41 @@
+<?php // lint >= 8.0
+
+declare(strict_types = 1);
+
+namespace Bug13029;
+
+function foo(): void
+{
+	/** @var bool **/
+	$bool1 = true;
+	/** @var bool **/
+	$bool2 = false;
+
+	$x = match([$bool1, $bool2]) {
+		[true, false], [true, true] => 1,
+		[false, false] => 0,
+		[false, true] => -1,
+	};
+
+	/** @var int<0, 2> */
+	$int1 = 1;
+	/** @var int<0, 2> */
+	$int2 = 2;
+
+	$y = match([$int1, $int2]) {
+		[0, 0], [0, 1], [0, 2] => 1,
+		[1, 1], [1, 2], [1, 0] => 0,
+		[2, 1], [2, 0], [2, 2] => -1,
+	};
+
+	/** @var 0|1 **/
+	$int1 = 1;
+	/** @var 0|1 **/
+	$int2 = 0;
+
+	$z = match([$int1, $int2]) {
+		[1, 0], [1, 1] => 1,
+		[0, 0] => 0,
+		[0, 1] => -1,
+	};
+}