Added regression test (phpstan#5088)

Author: staabm

tests/PHPStan/Rules/Comparison/BooleanNotConstantConditionRuleTest.php

@@ -229,4 +229,10 @@ public function testBug5984(): void
 		$this->analyse([__DIR__ . '/data/bug-5984.php'], []);
 	}
 
+	public function testBug6702(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-6702.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -194,4 +194,10 @@ public function testBug13384b(): void
 		]);
 	}
 
+	public function testBug7699(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-7699.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-6702.php

@@ -0,0 +1,54 @@
+<?php declare(strict_types=1);
+
+namespace Bug6702;
+
+interface LineScanner
+{
+	function isDone(): bool;
+
+	function getColumn(): int;
+
+	/**
+	 * Reads the char at the current position and moves the cursor.
+	 * @phpstan-impure
+	 */
+	function readChar(): string;
+
+	function peekChar(int $offset = 0): string;
+
+	function scanChar(string $char): bool;
+}
+
+function minimumIndentation(LineScanner $scanner): ?int
+{
+	while (!$scanner->isDone() && $scanner->readChar() !== "\n") {
+	}
+
+	if ($scanner->isDone()) {
+		return $scanner->peekChar(-1) === "\n" ? -1 : null;
+	}
+
+	$min = null;
+	while (!$scanner->isDone()) {
+		// Consume the indentation
+		while (!$scanner->isDone()) {
+			$next = $scanner->peekChar();
+			if ($next !== ' ' && $next !== "\t") {
+				break;
+			}
+			$scanner->readChar();
+		}
+
+		if ($scanner->isDone() || $scanner->scanChar("\n")) {
+			continue;
+		}
+
+		$min = $min === null ? $scanner->getColumn() : min($min, $scanner->getColumn());
+
+		// Consume the rest of the line
+		while (!$scanner->isDone() && $scanner->readChar() !== "\n") {
+		}
+	}
+
+	return $min ?? -1;
+}

tests/PHPStan/Rules/Comparison/data/bug-7699.php

@@ -0,0 +1,10 @@
+<?php declare(strict_types=1);
+
+namespace Bug7699;
+
+$selections = isset($_GET['x']) ? explode(',', $_GET['x']) : [];
+while ($selections && $id = array_shift($selections)) {
+	if ($selections) {
+		var_dump('x');
+	}
+}

tests/PHPStan/Rules/Variables/IssetRuleTest.php

@@ -506,4 +506,11 @@ public function testBug10640(): void
 		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-10640.php'], []);
 	}
 
+	public function testBug9503(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+
+		$this->analyse([__DIR__ . '/data/bug-9503.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Variables/data/bug-9503.php

@@ -0,0 +1,19 @@
+<?php declare(strict_types=1);
+
+namespace Bug9503;
+
+class HelloWorld
+{
+	public function sayHello(string $str): bool
+	{
+		if (preg_match('~x(a)?(b)?~', $str, $matches) > 0) {
+			if (isset($matches[2]) && preg_match('~x2(a)?(b)?~', $matches[2], $matches) > 0) {
+				if (isset($matches[2])) {
+					return true;
+				}
+			}
+		}
+
+		return false;
+	}
+}