Setting reportIgnoresWithoutComments: true will disallow @phpstan-ignore-line and @phpstan-ignore-next-line

Author: ondrejmirtes

.github/workflows/e2e-tests.yml

@@ -303,8 +303,13 @@ jobs:
               cd e2e/report-ignores-without-comments
               OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan --error-format=raw")
               echo "$OUTPUT"
-              ../bashunit -a contains 'test.php:4:Ignore with identifier variable.undefined has no comment' "$OUTPUT"
+              ../bashunit -a contains 'test.php:4:Ignore with identifier variable.undefined has no comment.' "$OUTPUT"
+              ../bashunit -a contains 'test.php:4:Variable $undefined might not be defined.' "$OUTPUT"
               ../bashunit -a not_contains 'test.php:7' "$OUTPUT"
+              ../bashunit -a contains 'test.php:10:Ignoring all errors on a line is not allowed.' "$OUTPUT"
+              ../bashunit -a contains 'test.php:10:Variable $yetAnotherUndefined might not be defined.' "$OUTPUT"
+              ../bashunit -a contains 'test.php:12:Ignoring all errors on a line is not allowed.' "$OUTPUT"
+              ../bashunit -a contains 'test.php:12:Variable $yetYetAnotherUndefined might not be defined.' "$OUTPUT"
 
     steps:
       - name: Harden the runner (Audit all outbound calls)

e2e/report-ignores-without-comments/test.php

@@ -5,3 +5,8 @@
 
 // @phpstan-ignore variable.undefined (this one has a comment so no error)
 echo $anotherUndefined;
+
+// @phpstan-ignore-next-line
+echo $yetAnotherUndefined;
+
+echo $yetYetAnotherUndefined; // @phpstan-ignore-line

src/Analyser/FileAnalyser.php

@@ -135,6 +135,17 @@ public function analyseFile(
 					foreach ($linesToIgnore as $ignoredFile => $lines) {
 						foreach ($lines as $line => $identifiers) {
 							if ($identifiers === null) {
+								$fileErrors[] = (new Error(
+									'Ignoring all errors on a line is not allowed.',
+									$ignoredFile,
+									$line,
+									false,
+									$ignoredFile,
+									null,
+									'Use @phpstan-ignore with an identifier and a comment (in parentheses).',
+								))->withIdentifier('ignore.allLineErrors');
+								unset($linesToIgnore[$ignoredFile][$line]);
+								unset($unmatchedLineIgnores[$ignoredFile][$line]);
 								continue;
 							}
 
@@ -152,6 +163,8 @@ public function analyseFile(
 									null,
 									'Explain why this ignore is necessary in parentheses after the identifier.',
 								))->withIdentifier('ignore.noComment');
+								unset($linesToIgnore[$ignoredFile][$line]);
+								unset($unmatchedLineIgnores[$ignoredFile][$line]);
 							}
 						}
 					}